Add ability to ignore index migration warnings #119066
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewhiting
added
>enhancement
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @lukewhiting, I've created a changelog YAML for you. |
|
Changes to be made:
|
| IndexVersions.ZERO, | ||
| IndexVersion::fromId, | ||
| Property.IndexScope, | ||
| Property.Dynamic |
There was a problem hiding this comment.
I thin it might make sense to add the nonCopyableOnResize property so this get's removed if the index is cloned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new setting to allow the user to ignore index deprecation warnings and integrates it across various downstream methods such as deprecation checks and data stream reindexing. The changes include adding a new setting, updating existing methods to accommodate this setting, and adding tests to ensure the new functionality works as expected.
New Setting Addition:
IGNORE_INDEX_DEPRECATION_WARNING_FOR_VERSION_SETTINGinIndexMetadata.javato control index deprecation warnings.IndexScopedSettings.javato include the new setting.Integration of New Setting:
TransportResumeFollowAction.javato include the new setting in the list of settings.DeprecatedIndexPredicate.javato utilize the new setting in thereindexRequiredandisNotIgnoredmethods.Deprecation Checks:
DataStreamDeprecationChecks.javaandIndexDeprecationChecks.javato include the new setting and provide more detailed deprecation information. [1] [2]Testing:
DataStreamDeprecationChecksTests.javaandIndexDeprecationChecksTests.javato validate the new setting and its impact on deprecation checks. [1] [2]