Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for indexing failures due to version conflicts #119067

Merged
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
ab95841
WIP
albertzaharovits Dec 11, 2024
890452c
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Dec 12, 2024
0d4688b
OK
albertzaharovits Dec 12, 2024
d3a0e62
Some test
albertzaharovits Dec 12, 2024
98654c9
test method rename
albertzaharovits Dec 12, 2024
2ee0d86
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Dec 16, 2024
6a7161c
polish negative IT
albertzaharovits Dec 16, 2024
dbc2d85
IT nits
albertzaharovits Dec 17, 2024
df44c5a
IT finally done
albertzaharovits Dec 19, 2024
c058226
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Dec 19, 2024
e10d2fc
[CI] Auto commit changes from spotless
elasticsearchmachine Dec 19, 2024
9370a6d
Fix tests compile
albertzaharovits Dec 19, 2024
d9ac566
DataStreamAutoshardingIT
albertzaharovits Dec 19, 2024
4b724a1
Fix NodeIndexingMetricsIT
albertzaharovits Dec 19, 2024
aef63c1
IndicesMetrics
albertzaharovits Dec 19, 2024
be37282
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Dec 19, 2024
2e1a075
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Dec 24, 2024
d8a449f
IndicesMetricsIT
albertzaharovits Dec 26, 2024
069b3b6
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Dec 26, 2024
2fd846a
[CI] Auto commit changes from spotless
elasticsearchmachine Dec 26, 2024
91d36d3
RestShardStats
albertzaharovits Dec 26, 2024
c208d14
RestShardsActionTests
albertzaharovits Dec 26, 2024
931d778
Fix test/cat.shards/10_basic.yml
albertzaharovits Dec 26, 2024
a432109
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Dec 26, 2024
bb18ea8
[CI] Auto commit changes from spotless
elasticsearchmachine Dec 26, 2024
0dc3671
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Dec 27, 2024
c1ea675
Spotless
albertzaharovits Dec 27, 2024
8b479a5
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Dec 29, 2024
aa4a283
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Dec 31, 2024
d8e23d2
RestIndicesAction RestNodesAction
albertzaharovits Jan 1, 2025
8ec3ad1
[CI] Auto commit changes from spotless
elasticsearchmachine Jan 1, 2025
e4a658b
IndexShardTests
albertzaharovits Jan 1, 2025
4e1ba34
rename WithVersionConflict -> DueToVersionConflict
albertzaharovits Jan 1, 2025
5a35cec
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Jan 1, 2025
73ade62
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Jan 7, 2025
108645b
Nit
albertzaharovits Jan 7, 2025
b38a937
Separate metric (rather than attribute) for version_conflict indexing…
albertzaharovits Jan 7, 2025
c90e42b
[CI] Auto commit changes from spotless
elasticsearchmachine Jan 7, 2025
2fbc503
Update docs/changelog/119067.yaml
albertzaharovits Jan 7, 2025
342101e
testIndexingErrorsDueToVersionConflict with successful indexing too
albertzaharovits Jan 7, 2025
407529c
Doc _cat actions
albertzaharovits Jan 7, 2025
3185769
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Jan 7, 2025
969cfc7
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Jan 8, 2025
d2c8793
Merge branch 'main' into index-metrics-version-conflicts
albertzaharovits Jan 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
OK
  • Loading branch information
albertzaharovits committed Dec 12, 2024
commit 0d4688b711dee7cd9d50877ed9b7b75a97ba55c7
Original file line number Diff line number Diff line change
Expand Up @@ -356,24 +356,23 @@ private void registerAsyncMetrics(MeterRegistry registry) {
"Total number of failed indexing operations",
"operations",
() -> List.of(
// new LongWithAttributes(
// Optional.ofNullable(stats.getOrRefresh())
// .map(o -> o.getIndices())
// .map(o -> o.getIndexing())
// .map(o -> o.getTotal())
// .map(o -> o.getIndexFailedCount())
// .orElse(0L),
// Map.of("es.indexing.indexing.failed.cause", "any")
// ),
new LongWithAttributes(
Optional.ofNullable(stats.getOrRefresh())
.map(o -> o.getIndices())
.map(o -> o.getIndexing())
.map(o -> o.getTotal())
.map(o -> o.getIndexFailedCount())
.orElse(0L),
Map.of("es.indexing.indexing.failed.cause", "any")
),
new LongWithAttributes(
Optional.ofNullable(stats.getOrRefresh())
.map(o -> o.getIndices())
.map(o -> o.getIndexing())
.map(o -> o.getTotal())
.map(o -> o.getIndexFailedWithVersionConflictCount())
.orElse(0L),
// Map.of("es.indexing.indexing.failed.cause", "version_conflict")
Map.of()
Map.of("es.indexing.indexing.failed.cause", "version_conflict")
)
)
)
Expand Down