Use synthetic recovery source by default for TSDB and LogsDB #119110
+427
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7bcd751.
| @@ -655,9 +654,64 @@ public Iterator<Setting<?>> settings() { | |||
| Property.Final | |||
| ); | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
This change is just a result of reordering settings in such a way that static initialization happens in the right order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experimented with using synthetic source for recovery and observed quite positive impact
on indexing throughput by means of our nightly Rally benchmarks. As a result, here we enable
it by default when synthetic source is used. To be more precise, if
index.mapping.source.modesetting is
syntheticwe enable recovery source by means of synthetic source.I had to move the
index.mapping.source.modesetting toIndexSettingsbecause of dependeciesand because of the initialization order of static fields for classes
IndexSettingsandSourceFieldMapper.Not initializing settings
index.mode,index.mapping.source.mode, andindex.recovery.use_synthetic_sourcein the right order results in multiple
NullPointerException.