Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Removing unnecessary inference plugin assertion #119228

Merged

Conversation

jonathan-buttner
Copy link
Contributor

@jonathan-buttner jonathan-buttner commented Dec 23, 2024

Accidentally left an assert in this PR: #118999

The assert doesn't currently hurt anything but it's not needed and is checking the wrong variable anyway so I'm remove it.

We don't need to backport this as I've already removed it from the backports for the original PR:
8.x
8.17
8.16

@jonathan-buttner jonathan-buttner added >refactoring :ml Machine learning Team:ML Meta label for the ML team Feature:GenAI Features around GenAI v9.0.0 labels Dec 23, 2024
@jonathan-buttner jonathan-buttner changed the title [ML] Removing assert [ML] Removing unnecessary inference plugin assertion Dec 23, 2024
@jonathan-buttner jonathan-buttner marked this pull request as ready for review December 23, 2024 18:07
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Member

@maxhniebergall maxhniebergall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-buttner jonathan-buttner merged commit 81772c3 into elastic:main Dec 23, 2024
16 checks passed
@jonathan-buttner jonathan-buttner deleted the ml-plugin-remove-assert-check branch December 23, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:GenAI Features around GenAI :ml Machine learning >refactoring Team:ML Meta label for the ML team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants