Rename methods in ChunkedToXContentHelper to be clearer #119342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte
approved these changes
Jan 9, 2025
| * @return Singleton iterator for the given item. | ||
| */ | ||
| public static Iterator<ToXContent> chunk(ToXContent item) { | ||
| return Iterators.single(item); |
There was a problem hiding this comment.
Nit: should you remove singleChunck? It looks like a leftover
There was a problem hiding this comment.
It's currently used by Serverless, tidying up Serverless uses I'll do separately.
| @@ -247,7 +247,7 @@ public Iterator<? extends ToXContent> toXContentChunked(ToXContent.Params params | |||
| ChunkedToXContentHelper.field(PARTIAL_FIELD.getPreferredName(), getClusterStateCount(Cluster.Status.PARTIAL)), | |||
| ChunkedToXContentHelper.field(FAILED_FIELD.getPreferredName(), getClusterStateCount(Cluster.Status.FAILED)), | |||
| // each Cluster object defines its own field object name | |||
| ChunkedToXContentHelper.xContentFragmentValuesMapCreateOwnName("details", clusterInfo), | |||
| ChunkedToXContentHelper.object("details", clusterInfo.values().iterator()), | |||
There was a problem hiding this comment.
Is this equivalent? The implementations are surely different, but maybe the end result is the same. Just checking.
There was a problem hiding this comment.
It is equivalent - the chunk counts dont change, and the tests still all pass (notice xContentFragmentValuesMapCreateOwnName is just calling getValue.toXContent, ignoring the key entirely)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename/consolidate methods in
ChunkedToXContentHelper