Some cleanups to OperationRouting #119440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two small cleanups that remove duplication and dead-code: 1. The shardId method can be made `static`, it's only non-static use in mocking was unnecessary and could just be deleted 2. Filtering for searchable shards is the same logic now for stateful and stateless. We also only use it when building a filtered `PlainShardIterator` so it might as well live there to remove some duplication.
original-brownbear
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
javanna
approved these changes
Jan 6, 2025
original-brownbear
added
auto-backport
|
Thanks Luca! |
💚 Backport successful
|
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 6, 2025
Two small cleanups that remove duplication and dead-code: 1. The shardId method can be made `static`, it's only non-static use in mocking was unnecessary and could just be deleted 2. Filtering for searchable shards is the same logic now for stateful and stateless. We also only use it when building a filtered `PlainShardIterator` so it might as well live there to remove some duplication.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 7, 2025
Two small cleanups that remove duplication and dead-code: 1. The shardId method can be made `static`, it's only non-static use in mocking was unnecessary and could just be deleted 2. Filtering for searchable shards is the same logic now for stateful and stateless. We also only use it when building a filtered `PlainShardIterator` so it might as well live there to remove some duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small cleanups that remove duplication and dead-code:
static, it's only non-static use in mocking was unnecessary and could just be deletedPlainShardIteratorso it might as well live there to remove some duplication.