ESQL: Explain IN #119514
Merged
ESQL: Explain IN #119514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds javadoc to IN to explain it's three-valued null logic and why it isn't using the standard code generators.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
not-napoleon
reviewed
Jan 3, 2025
There was a problem hiding this comment.
So, wait, the behavior here is that, if the set to match contains a null, we return true if the value to test matches one of the non-null values, and null if it does not? If that's the intent, I think we should be explicit about it, I had to read those rules three times to understand this was how it worked.
.../src/main/java/org/elasticsearch/xpack/esql/expression/predicate/operator/comparison/In.java
Outdated
Show resolved
Hide resolved
not-napoleon
approved these changes
Jan 6, 2025
|
Oh shoot. I didn't auto-backport. I'll do it by hand. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 7, 2025
* ESQL: Explain IN Adds javadoc to IN to explain it's three-valued null logic and why it isn't using the standard code generators. * Paste more examples
|
backport: #119514 |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds javadoc to IN to explain it's three-valued null logic and why it isn't using the standard code generators.
Relates to #119480