Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rejected-requests.asciidoc #119547

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Update rejected-requests.asciidoc #119547

merged 3 commits into from
Jan 7, 2025

Conversation

IanLee1521
Copy link
Contributor

I believe this is a typo, as in our 8.16.1 cluster this field appears to be called combined_coordinating_and_primary

      "indexing_pressure": {
        "memory": {
          "current": {
            "combined_coordinating_and_primary": "0b",
            "combined_coordinating_and_primary_in_bytes": 0,
            "coordinating": "0b",
            "coordinating_in_bytes": 0,
            "primary": "0b",
            "primary_in_bytes": 0,
            "replica": "0b",
            "replica_in_bytes": 0,
            "all": "0b",
            "all_in_bytes": 0
          },

@IanLee1521
Update rejected-requests.asciidoc
69f7b32 
I believe this is a typo, as in our 8.16.1 cluster this field appears to be called `combined_coordinating_and_primary`
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.17.1 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 4, 2025
@kingherc kingherc self-assigned this Jan 7, 2025
@kingherc kingherc added the :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. label Jan 7, 2025
@elasticsearchmachine elasticsearchmachine added Team:Distributed Indexing Meta label for Distributed Indexing team and removed needs:triage Requires assignment of a team area label labels Jan 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

@kingherc kingherc added >docs General docs changes v9.0.0 v8.18.0 auto-backport Automatically create backport pull requests when merged and removed v8.17.1 labels Jan 7, 2025
@kingherc
Copy link
Contributor

kingherc commented Jan 7, 2025

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Jan 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@kingherc
Copy link
Contributor

kingherc commented Jan 7, 2025

@IanLee1521 thank you for the PR! Could I ask that you re-target it for the main branch? I'll do the necessary backporting to 8.x version.

@leemthompo
Copy link
Contributor

leemthompo commented Jan 7, 2025 •
edited
Loading

Could I ask that you re-target it for the main branch? I'll do the necessary backporting to 8.x version.

@kingherc with the backport labels the cherrypicking will work to open PRs against the versions tagged, with 9.0 representing main and 8.18.0 representing 8.x, so don't actually need a fresh PR

@leemthompo
Copy link
Contributor

@elasticsearchmachine test this

@leemthompo
Copy link
Contributor

run docs-build

@kingherc
Copy link
Contributor

kingherc commented Jan 7, 2025

Ah thanks @leemthompo , didn't know. Added labels, feel free to merge if you see it green first.

@kingherc kingherc requested a review from leemthompo January 7, 2025 15:11
@kingherc
Copy link
Contributor

kingherc commented Jan 7, 2025

@leemthompo can you proceed with merging and backporting? As I haven't done it with main before, I'd prefer to spectate on this one :)

@kingherc kingherc assigned leemthompo and unassigned kingherc Jan 7, 2025
@leemthompo leemthompo merged commit 1acda8c into elastic:8.17 Jan 7, 2025
7 checks passed
@leemthompo leemthompo mentioned this pull request Jan 7, 2025
Merged
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 7, 2025
@IanLee1521 @leemthompo
Update rejected-requests.asciidoc (elastic#119547)
ebaf13c 
I believe this is a typo, as in our 8.16.1 cluster this field appears to be called `combined_coordinating_and_primary`
This was referenced Jan 7, 2025
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.16
✅ main
✅ 8.x

leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 7, 2025
@IanLee1521 @leemthompo
Update rejected-requests.asciidoc (elastic#119547)
0fc6058 
I believe this is a typo, as in our 8.16.1 cluster this field appears to be called `combined_coordinating_and_primary`
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jan 7, 2025
@IanLee1521 @leemthompo
Update rejected-requests.asciidoc (elastic#119547)
4e2d6de 
I believe this is a typo, as in our 8.16.1 cluster this field appears to be called `combined_coordinating_and_primary`
elasticsearchmachine pushed a commit that referenced this pull request Jan 7, 2025
@leemthompo @IanLee1521
Update rejected-requests.asciidoc (#119547) (#119672)
e3352ad 
I believe this is a typo, as in our 8.16.1 cluster this field appears to be called `combined_coordinating_and_primary`

Co-authored-by: Ian Lee <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jan 7, 2025
@leemthompo @IanLee1521
Update rejected-requests.asciidoc (#119547) (#119674)
3692fc2 
I believe this is a typo, as in our 8.16.1 cluster this field appears to be called `combined_coordinating_and_primary`

Co-authored-by: Ian Lee <[email protected]>
@IanLee1521 IanLee1521 deleted the patch-2 branch January 7, 2025 17:16
leemthompo added a commit that referenced this pull request Jan 9, 2025
@leemthompo @IanLee1521
Update rejected-requests.asciidoc (#119547) (#119673)
996a4f8 
I believe this is a typo, as in our 8.16.1 cluster this field appears to be called `combined_coordinating_and_primary`

Co-authored-by: Ian Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo approved these changes

Assignees

@leemthompo leemthompo

Labels
auto-backport Automatically create backport pull requests when merged :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Distributed Indexing Meta label for Distributed Indexing team Team:Docs Meta label for docs team v8.16.0 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IanLee1521 @elasticsearchmachine @kingherc @leemthompo @elasticmachine