[Gradle] Make rolling upgrade tests configuration cache compatible #119577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
Example run with configuration cache enabled: https://gradle-enterprise.elastic.co/s/4xkjqhtp4wgdg |
breskeby
force-pushed
the
rolling-upgrade-cc-compatibility
branch
from
c6e6ba3 to
b153a40
Compare
breskeby
commented
Jan 6, 2025
| @@ -26,7 +26,7 @@ public interface TestClustersAware extends Task { | |||
| Collection<ElasticsearchCluster> getClusters(); | |||
|
|
|||
| @ServiceReference(REGISTRY_SERVICE_NAME) | |||
| Property<TestClustersRegistry> getRegistery(); | |||
| Property<TestClustersRegistry> getRegistry(); | |||
There was a problem hiding this comment.
fix typo on the way
breskeby
force-pushed
the
rolling-upgrade-cc-compatibility
branch
3 times, most recently
from
38ba572 to
f095bb1
Compare
breskeby
commented
Jan 7, 2025
| systemProperty 'tests.bwc_nodes_version', bwcVersion.toString().replace('-SNAPSHOT', '') | ||
| systemProperty 'tests.new_nodes_version', project.version.toString().replace('-SNAPSHOT', '') | ||
| // onlyIf("BWC tests disabled") { project.bwc_tests_enabled } |
There was a problem hiding this comment.
reinstantiated as we walk by
breskeby
force-pushed
the
rolling-upgrade-cc-compatibility
branch
from
d08c6c6 to
0f25872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, all rolling upgrade tests that involve a
nextNodeToNextVersionupdate are gradle configuration cache compatible.Simplify API around test cluster registry and cc compatible usage of test cluster in TestClusterAware tasks.