Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable N-2 BWC tests for non-snapshot builds #119583

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jan 6, 2025

The tests added in #119468 do not work when executed in the release-test pipeline: at some point a 9.0 non-snapshot node tries to join the 8.18.0-SNAPSHOT cluster which is impossible due to a missing
esql.metrics_syntax feature which is only declared in snapshot builds.

Additionaly, the tests rely on unrelease code in 8.x so they won't work until 8.18.0 is released.

I don't know how we deal with such issues today, but I'd like to unmute the tests so that they are executed on CI while being disabled in release-test.

Releates #119550

The tests added in elastic#119468 do not work when executed
in the `release-test` pipeline: at some point a 9.0
non-snapshot node tries to join the 8.18.0-SNAPSHOT
cluster which is impossible due to a missing
`esql.metrics_syntax` feature which is only declared
in snapshot builds.

Additionaly, the tests rely on unrelease code in 8.x
so they won't work until 8.18.0 is released.

I don't know how we deal with such issues today, but
I'd like to unmute the tests so that they are executed
on CI while being disabled in `release-test`.
@tlrx tlrx added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v9.0.0 labels Jan 6, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Indexing Meta label for Distributed Indexing team label Jan 6, 2025
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tlrx tlrx added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 8, 2025
@elasticsearchmachine elasticsearchmachine merged commit 447dcaa into elastic:main Jan 8, 2025
16 checks passed
@tlrx tlrx deleted the 2025/01/06/disable-N-2-BWC-tests-for-release-tests branch January 8, 2025 11:37
@tlrx
Copy link
Member Author

tlrx commented Jan 8, 2025

Thanks Henning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. Team:Distributed Indexing Meta label for Distributed Indexing team >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants