Use unsecure entropy source in docker packaging tests #119598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
rjernst
approved these changes
Jan 6, 2025
| @@ -112,6 +115,13 @@ String build() { | |||
| // Limit container memory | |||
| cmd.add("--memory " + memory); | |||
|
|
|||
| // Add default java opts | |||
| if (this.envVars.containsKey("CLI_JAVA_OPTS")) { | |||
| this.envVars.put("CLI_JAVA_OPTS", this.envVars.get("CLI_JAVA_OPTS") + " " + DEFAULT_JAVA_OPTS); | |||
There was a problem hiding this comment.
Should we use this with ES_JAVA_OPTS as well?
There was a problem hiding this comment.
Should we use this with ES_JAVA_OPTS as well?
We could. It doesn't affect this particular issue as security auto config is done in the CLI.
There was a problem hiding this comment.
I went ahead and added it on the chance we add anything else to DEFAULT_JAVA_OPTS.
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 6, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 6, 2025
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Jan 6, 2025
mark-vieira
added a commit
that referenced
this pull request
Jan 6, 2025
mark-vieira
added a commit
that referenced
this pull request
Jan 6, 2025
mark-vieira
added a commit
that referenced
this pull request
Jan 6, 2025
sarog
pushed a commit
to sarog/elasticsearch
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #119441 thread dumps indicate container startup hung up in security auto-configuration generating certificates. This is likely due to a low source of entropy during these tests as they run serially so there is little other activity on the host machine. This change configures ES to use
/dev/urandomas the entropy source, which while less secure, should alleviate the problem.