Add support for highlighting the new format of the semantic text field #119604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adapts the semantic highlighter to work with the new format introduced in elastic#119183.
jimczi
added
>non-issue
:SearchOrg/Relevance
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
kderusso
approved these changes
Jan 6, 2025
...rence/src/main/java/org/elasticsearch/xpack/inference/highlight/SemanticTextHighlighter.java
Outdated
Show resolved
Hide resolved
...rence/src/main/java/org/elasticsearch/xpack/inference/highlight/SemanticTextHighlighter.java
Outdated
Show resolved
Hide resolved
...src/yamlRestTest/resources/rest-api-spec/test/inference/90_semantic_text_highlighter_bwc.yml
Show resolved
Hide resolved
Mikep86
reviewed
Jan 6, 2025
...rence/src/main/java/org/elasticsearch/xpack/inference/highlight/SemanticTextHighlighter.java
Outdated
Show resolved
Hide resolved
...nce/src/yamlRestTest/resources/rest-api-spec/test/inference/90_semantic_text_highlighter.yml
Outdated
Show resolved
Hide resolved
...src/yamlRestTest/resources/rest-api-spec/test/inference/90_semantic_text_highlighter_bwc.yml
Outdated
Show resolved
Hide resolved
...src/yamlRestTest/resources/rest-api-spec/test/inference/90_semantic_text_highlighter_bwc.yml
Show resolved
Hide resolved
…inference/highlight/SemanticTextHighlighter.java Co-authored-by: Kathleen DeRusso <[email protected]>
…inference/highlight/SemanticTextHighlighter.java Co-authored-by: Kathleen DeRusso <[email protected]>
jimczi
added
the
auto-backport
jimczi
added
backport pending
and removed
auto-backport
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jan 7, 2025
elastic#119604) This change adapts the semantic highlighter to work with the new format introduced in elastic#119183. Co-authored-by: Kathleen DeRusso <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 7, 2025
#119604) (#119657) This change adapts the semantic highlighter to work with the new format introduced in #119183. Co-authored-by: Kathleen DeRusso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adapts the semantic highlighter to work with the new format introduced in #119183.