Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dead code in o.e.s.a.b.t.heuristic #119633

Merged

Conversation

original-brownbear
Copy link
Member

Random finds from auditing code for batched execution: The builders are unused and the equals implementations are unnecessarily verbose, cleaning both up here.

Random finds from auditing code for batched execution:
The builders are unused and the `equals` implementations are unnecessarily verbose, cleaning both up here.
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added v9.0.0 Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jan 7, 2025
@original-brownbear original-brownbear added auto-backport Automatically create backport pull requests when merged v8.18.0 labels Jan 7, 2025
@original-brownbear
Copy link
Member Author

Thanks Nik!

@original-brownbear original-brownbear merged commit 11ece15 into elastic:main Jan 7, 2025
16 checks passed
@original-brownbear original-brownbear deleted the random-dead-code-aggs branch January 7, 2025 14:21
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jan 7, 2025
Random finds from auditing code for batched execution:
The builders are unused and the `equals` implementations are unnecessarily verbose, cleaning both up here.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

elasticsearchmachine pushed a commit that referenced this pull request Jan 7, 2025
Random finds from auditing code for batched execution:
The builders are unused and the `equals` implementations are unnecessarily verbose, cleaning both up here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants