ESQL: Add UNSUPPORTED type in unit tests #119639
Merged
+49
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalLalouche
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
GalLalouche
force-pushed
the
tests/unsupported_types
branch
from
850f6cb to
5e27838
Compare
idegtiarenko
approved these changes
Jan 7, 2025
GalLalouche
force-pushed
the
tests/unsupported_types
branch
from
5e27838 to
96ed2f0
Compare
craigtaverner
approved these changes
Jan 7, 2025
alex-spies
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks @GalLalouche ! I agree with this change, as it makes the expected results more correct.
nik9000
approved these changes
Jan 7, 2025
Unsupported type is a very specific column type caused by unresolved unions. Or at least, no other unit tests failed due to this change ¯\_(ツ)_/¯. |
Small addition to tests, aligning their types better with production code.
GalLalouche
force-pushed
the
tests/unsupported_types
branch
from
96ed2f0 to
005d90a
Compare
I think there's other examples, although we likely just don't have unit tests for them. E.g. nested and flattened fields aren't supported and should produce this column type - c.f. here. |
💚 Backport successful
|
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Jan 7, 2025
Small addition to tests, aligning their types better with production code.
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Jan 8, 2025
Small addition to tests, aligning their types better with production code.
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Jan 9, 2025
Small addition to tests, aligning their types better with production code.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small addition to tests, aligning their types better with production code.