-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable query rewrites on the coordinator for ESQL #119667
Merged
Merged
+0
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
label
Jan 7, 2025
Pinging @elastic/es-analytical-engine (Team:Analytics) |
carlosdelest
approved these changes
Jan 8, 2025
ChrisHegarty
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fang-xing-esql
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
ioanatia
added
auto-backport
Automatically create backport pull requests when merged
v8.18.0
labels
Jan 9, 2025
💚 Backport successful
|
ioanatia
added a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jan 9, 2025
* Enable query rewrites on the coordinator for ESQL * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]>
15 tasks
elasticsearchmachine
added a commit
that referenced
this pull request
Jan 9, 2025
* Enable query rewrites on the coordinator for ESQL * [CI] Auto commit changes from spotless --------- Co-authored-by: elasticsearchmachine <[email protected]> Co-authored-by: Felix Barnsteiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/ES|QL
AKA ESQL
auto-backport
Automatically create backport pull requests when merged
>non-issue
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables full text functions to be translated to query builders on the coordinator.
The functionality was added in #118676
This change does not enable semantic search in ES|QL.
While this is a requirement for semantic search, this is a general functionality that we can benefit all search functions.
We initially had a conservative approach and added this functionality behind a snapshot, reusing the
SEMANTIC_TEXT_TYPE
capability, but we can take it out of snapshot irrespective of semantic search.