Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify test class hierarchy in old-repository-versions-compatibility #119670

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

javanna
Copy link
Member

@javanna javanna commented Jan 7, 2025

The test method does not need to be repeated in every test class, and the two base test classes can be abstract.

Meanwhile I also corrected javadocs on DocValueOnlyFieldsIT that were outdated.

@javanna javanna added >test Issues or PRs that are addressing/adding tests :Search Foundations/Search Catch all for Search Foundations v9.0.0 labels Jan 7, 2025
@javanna javanna requested a review from drempapis January 7, 2025 15:13
@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jan 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Copy link
Contributor

@drempapis drempapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@javanna javanna merged commit 9fdfc79 into elastic:main Jan 8, 2025
16 checks passed
@javanna javanna deleted the test/simplify_old_versions branch January 8, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants