-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deprecated tracing.apm settings to critical #119677
Merged
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
added
v8.18.0
v9.0.0
and removed
Team:Core/Infra
Meta label for core/infra team
v9.0.0
labels
Jan 7, 2025
mosche
added
auto-backport
Automatically create backport pull requests when merged
and removed
Team:Core/Infra
Meta label for core/infra team
labels
Jan 7, 2025
rjernst
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merging this as |
💚 Backport successful
|
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Core/Infra/Metrics
Metrics and metering infrastructure
>non-issue
Team:Core/Infra
Meta label for core/infra team
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tracing.apm.*
deprecations have to be bumped to critical to be shown in the Kibana Upgrade assistant.So far we've considered these to be internal / undocumented, there's no "official" deprecation note for these yet.
Wondering, should this be tagged
>deprecation
or not?