Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deprecated tracing.apm settings to critical #119677

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

mosche
Copy link
Contributor

@mosche mosche commented Jan 7, 2025

The tracing.apm.* deprecations have to be bumped to critical to be shown in the Kibana Upgrade assistant.

So far we've considered these to be internal / undocumented, there's no "official" deprecation note for these yet.
Wondering, should this be tagged >deprecation or not?

@mosche mosche added the :Core/Infra/Metrics Metrics and metering infrastructure label Jan 7, 2025
@mosche mosche requested a review from a team January 7, 2025 16:01
@elasticsearchmachine elasticsearchmachine added v9.0.0 Team:Core/Infra Meta label for core/infra team labels Jan 7, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@mosche mosche added v8.18.0 v9.0.0 and removed Team:Core/Infra Meta label for core/infra team v9.0.0 labels Jan 7, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jan 7, 2025
@mosche mosche added auto-backport Automatically create backport pull requests when merged and removed Team:Core/Infra Meta label for core/infra team labels Jan 7, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jan 7, 2025
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mosche
Copy link
Contributor Author

mosche commented Jan 8, 2025

Merging this as >non-issue without a deprecation note as these settings are undocumented / not officially supported.

@mosche mosche merged commit eb5ce98 into elastic:main Jan 8, 2025
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

mosche added a commit to mosche/elasticsearch that referenced this pull request Jan 8, 2025
@mosche mosche deleted the v9/ENG-10293-bump-to-critical branch January 8, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Metrics Metrics and metering infrastructure >non-issue Team:Core/Infra Meta label for core/infra team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants