[Entitlements] No SecurityManager when entitlements are enabled #119689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entitlements are enabled
ldematte
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
💔 Backport failed
You can use sqren/backport to manually backport by running |
ldematte
added a commit
that referenced
this pull request
Jan 8, 2025
…entitlements are enabled (#119689)
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Jan 8, 2025
…entitlements are enabled (elastic#119689)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the SecurityManager is still partially initialized and checked to be present, even when entitlements are enabled - it is just a "all permission" SM, but it's there and it may interfere with entitlements IT tests (that's how I found it was still present).
This PR adjusts Bootstrap and JVM options to ensure the SM is never set or invoked when entitlements are enabled.