Skip HealthNodeUpgradeIT for some rolling upgrades

[PeteGillinElastic]

This excludes the HealthNodeUpgradeIT test for the rolling upgrade tests which use a cluster with a mix of either 8.5.3 or 8.6.2 nodes, which serve the health endpoint at _internal/_health, and 8.last nodes, which serve it at _health_report. There is no sensible and reliable way to test the endpoint in such clusters.

Closes #118157
Closes #118158

[elasticsearchmachine]

Pinging @elastic/es-data-management (Team:Data Management)

[PeteGillinElastic]

N.B. Before this PR, the test appears to have been muted entirely. After this PR, it is muted only for these two BWC rolling upgrade versions. So this does add some missing coverage.

[gmarouli]

I was looking into the test:

if (clusterHasFeature("health.supports_health")) {
            assertBusy(() -> {
                Response response = client().performRequest(new Request("GET", "_cat/tasks"));
                String tasks = EntityUtils.toString(response.getEntity(), StandardCharsets.UTF_8);
                assertThat(tasks, Matchers.containsString("health-node"));
            });
            assertBusy(() -> {
                String path = clusterHasFeature("health.supports_health_report_api") ? "_health_report" : "_internal/_health";
                Response response = client().performRequest(new Request("GET", path));
                Map<String, Object> health_report = entityAsMap(response.getEntity());
                assertThat(health_report.get("status"), equalTo("green"));
            });
        }

And I am wondering, instead of adding these explicit mutes, shouldn't we just use clusterHasFeature("health.supports_health_report_api)" in the if statement?

[PeteGillinElastic]

I was looking into the test:

if (clusterHasFeature("health.supports_health")) {
            assertBusy(() -> {
                Response response = client().performRequest(new Request("GET", "_cat/tasks"));
                String tasks = EntityUtils.toString(response.getEntity(), StandardCharsets.UTF_8);
                assertThat(tasks, Matchers.containsString("health-node"));
            });
            assertBusy(() -> {
                String path = clusterHasFeature("health.supports_health_report_api") ? "_health_report" : "_internal/_health";
                Response response = client().performRequest(new Request("GET", path));
                Map<String, Object> health_report = entityAsMap(response.getEntity());
                assertThat(health_report.get("status"), equalTo("green"));
            });
        }

And I am wondering, instead of adding these explicit mutes, shouldn't we just use clusterHasFeature("health.supports_health_report_api)" in the if statement?

Yeah, I think that should work. (It actually crossed my mind, I don't remember why I went this route.) I'll give it a go.

[PeteGillinElastic]

Yeah, that works, and avoids hard-coding the version numbers in question. I've verified that the assertion does run and passes for :qa:rolling-upgrade:v8.7.0#bwcTest. PTAL.

[gmarouli]

LGTM! Thanks for fixing this!