Nullify sourceAsMap once a search hit is processed #119734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
original-brownbear
approved these changes
Jan 8, 2025
iverase
added
the
auto-backport
💚 Backport successful
|
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Jan 8, 2025
he sourceAsMap can use a significant amount of memory, still it is only hold for caching. Therefore it might make sense to nullify it once a search hit is processed so we free that memory.
|
Would it be possible to have a test that verifies the new behavior introduced, or perhaps assertions that make sure that sourceMap is reset when needed? |
|
@javanna I sam reverting this change as I think you are right, this change needs some test and assertions. More over there are places where we are calling getSourceAsMap after generating the hits so we need to check if this is affecting those cases. |
iverase
added a commit
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sourceAsMap can use a significant amount of memory, still it is only hold for caching. Therefore it might make sense to nullify it once a search hit is processed so we free that memory.