-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strengthen encryption for elasticsearch-keystore tool to AES 256 #119749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest format version (7) of KeyStoreWrapper will be using a 256 bits key for the AES cipher. Closes #ES-10419
elasticsearchmachine
added
needs:triage
Requires assignment of a team area label
v9.0.0
labels
Jan 8, 2025
mosche
added
:Core/Infra/CLI
CLI utilities, scripts, and infrastructure
and removed
needs:triage
Requires assignment of a team area label
labels
Jan 8, 2025
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Hi @mosche, I've created a changelog YAML for you. |
rjernst
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I wonder if we should also backport to 8.x? 128 was a restriction for Java 8, which was 7.x.
...on/tools/keystore-cli/src/test/java/org/elasticsearch/cli/keystore/KeyStoreWrapperTests.java
Outdated
Show resolved
Hide resolved
mosche
added
v8.18.0
auto-backport
Automatically create backport pull requests when merged
labels
Jan 8, 2025
💚 Backport successful
|
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Jan 9, 2025
…stic#119749) The latest format version (7) of KeyStoreWrapper will be using a 256 bits key for the AES cipher. Closes #ES-10419
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 10, 2025
…9749) (#119827) The latest format version (7) of KeyStoreWrapper will be using a 256 bits key for the AES cipher. Closes #ES-10419 Co-authored-by: Felix Barnsteiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Core/Infra/CLI
CLI utilities, scripts, and infrastructure
>enhancement
Team:Core/Infra
Meta label for core/infra team
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest format version (7) of KeyStoreWrapper will be using a 256 bits key for the AES cipher.
Closes ES-10419