ESQL: connect_transport_exception should be thrown instead of verification_exception when ENRICH-ing if remote is disconnected
#119750
+743
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_exception` in ENRICH In the context of ENRICH, if a remote is disconnected and skip unavailable is set to `true`, then `verification_exception` is thrown instead of `connect_transport_exception`. This PR fixes this and adds the IT tests for ENRICH for RCS 1 and RCS 2.
pawankartik-elastic
added
v9.0.0
v8.18.0
:Search Foundations/Search
pawankartik-elastic
changed the title
verification_exception is thrown instead of connect_transport_exception in ENRICH when remote is disconnectedconnect_transport_exception should be thrown instead of verification_exception when ENRICH-ing if remote is disconnected
|
Hi @pawankartik-elastic, I've created a changelog YAML for you. |
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
pawankartik-elastic
added
the
auto-backport
quux00
changed the title
connect_transport_exception should be thrown instead of verification_exception when ENRICH-ing if remote is disconnectedconnect_transport_exception should be thrown instead of verification_exception when ENRICH-ing if remote is disconnected
quux00
approved these changes
Jan 8, 2025
pawankartik-elastic
added a commit
to pawankartik-elastic/elasticsearch
that referenced
this pull request
Jan 9, 2025
…fication_exception` when ENRICH-ing if remote is disconnected (elastic#119750) * fix: `verification_exception` is thrown instead of `connect_transport_exception` in ENRICH In the context of ENRICH, if a remote is disconnected and skip unavailable is set to `true`, then `verification_exception` is thrown instead of `connect_transport_exception`. This PR fixes this and adds the IT tests for ENRICH for RCS 1 and RCS 2. * Update docs/changelog/119750.yaml * Update 119750.yaml --------- Co-authored-by: Michael Peterson <[email protected]>
pawankartik-elastic
added a commit
to pawankartik-elastic/elasticsearch
that referenced
this pull request
Jan 9, 2025
…fication_exception` when ENRICH-ing if remote is disconnected (elastic#119750) * fix: `verification_exception` is thrown instead of `connect_transport_exception` in ENRICH In the context of ENRICH, if a remote is disconnected and skip unavailable is set to `true`, then `verification_exception` is thrown instead of `connect_transport_exception`. This PR fixes this and adds the IT tests for ENRICH for RCS 1 and RCS 2. * Update docs/changelog/119750.yaml * Update 119750.yaml --------- Co-authored-by: Michael Peterson <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 9, 2025
…fication_exception` when ENRICH-ing if remote is disconnected (#119750) (#119881) * fix: `verification_exception` is thrown instead of `connect_transport_exception` in ENRICH In the context of ENRICH, if a remote is disconnected and skip unavailable is set to `true`, then `verification_exception` is thrown instead of `connect_transport_exception`. This PR fixes this and adds the IT tests for ENRICH for RCS 1 and RCS 2. * Update docs/changelog/119750.yaml * Update 119750.yaml --------- Co-authored-by: Michael Peterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix,
VerificationExceptionis thrown if a remote is disconnected and skip unavailable istrueduringENRICH-ing. This is not what we want. It is expected that aConnectTransportExceptionbe thrown instead. This PR fixes it so that aConnectTransportExceptionis thrown and additionally addsENRICHtests for RCS 1 and RCS 2.