Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing DataStreamsUpgradeIT.testUpgradeDataStream when cluster major version is unchanged #119786

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fixing DataStreamsUpgradeIT.testUpgradeDataStream when cluster major version is unchanged #119786

merged 1 commit into from
Jan 8, 2025

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Jan 8, 2025 •
edited
Loading

If the major version of the cluster has not changed, then no reindex will happen. This means that there will be no rollover performed during that reindex. So we need to not expect rolloversPerformedByReindex to be included in the value for total_indices_in_data_stream.
Closes #119717

@masseyke masseyke added >test Issues or PRs that are addressing/adding tests :Data Management/Data streams Data streams and their lifecycles auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 labels Jan 8, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

parkertimmins
parkertimmins approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@parkertimmins parkertimmins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@masseyke masseyke merged commit 03d2df3 into elastic:main Jan 8, 2025
16 checks passed
@masseyke masseyke deleted the fix-119717 branch January 8, 2025 19:59
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 119786

masseyke added a commit to masseyke/elasticsearch that referenced this pull request Jan 8, 2025
@masseyke
Fixing DataStreamsUpgradeIT.testUpgradeDataStream when cluster major …
ddbe988 
…version is unchanged (elastic#119786)
@smalyshev
Copy link
Contributor

@masseyke the test is still marked as

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/119713")

should it be removed now?

elasticsearchmachine pushed a commit that referenced this pull request Jan 8, 2025
@masseyke
Fixing DataStreamsUpgradeIT.testUpgradeDataStream when cluster major …
e877304 
…version is unchanged (#119786) (#119795)

* Fixing DataStreamsUpgradeIT.testUpgradeDataStream when cluster major version is unchanged (#119786)

* Removed bad merge from muted-tests.yml
@masseyke
Copy link
Member Author

masseyke commented Jan 8, 2025

@masseyke the test is still marked as

@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/119713")

should it be removed now?

Oh I didn't realize that that was there! I thought everything was controlled via muted-tests.yml now. I had made/tested the fix before pulling this, and then only updated muted-tests.yml. I'll also remove this. Thanks.

@masseyke masseyke mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkertimmins parkertimmins parkertimmins approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] DataStreamsUpgradeIT testUpgradeDataStream failing
4 participants
@masseyke @elasticsearchmachine @smalyshev @parkertimmins