Fix trappy timeouts in GetAliasesRequest
#119817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the use of the trappy default master node timeout and configures a sensible default instead.
nielsbauman
added
:Data Management/Indices APIs
|
Pinging @elastic/es-data-management (Team:Data Management) |
nielsbauman
commented
Jan 9, 2025
| @@ -748,7 +748,7 @@ private void validateIndexBeforePromotion(String destinationIndexName, ClusterSt | |||
| private void updateEnrichPolicyAlias(ActionListener<IndicesAliasesResponse> listener) { | |||
| String enrichIndexBase = EnrichPolicy.getBaseName(policyName); | |||
| logger.debug("Policy [{}]: Promoting new enrich index [{}] to alias [{}]", policyName, enrichIndexName, enrichIndexBase); | |||
| GetAliasesRequest aliasRequest = new GetAliasesRequest(enrichIndexBase); | |||
| GetAliasesRequest aliasRequest = new GetAliasesRequest(ENRICH_MASTER_REQUEST_TIMEOUT, enrichIndexBase); | |||
There was a problem hiding this comment.
This existing timeout field felt more sensible than an infinite timeout.
| @@ -221,8 +221,9 @@ private void makeMlInternalIndicesHidden() { | |||
| logger.warn("One or more of the ML internal indices could not be made hidden."); | |||
| return; | |||
| } | |||
| GetAliasesRequest getAliasesRequest = new GetAliasesRequest().indices(mlHiddenIndexPatterns) | |||
| .indicesOptions(IndicesOptions.LENIENT_EXPAND_OPEN_CLOSED_HIDDEN); | |||
| GetAliasesRequest getAliasesRequest = new GetAliasesRequest(MasterNodeRequest.INFINITE_MASTER_NODE_TIMEOUT).indices( | |||
There was a problem hiding this comment.
Specified an infinite timeout here as this is an internal request - as per #107984.
| @@ -475,8 +476,10 @@ private void deleteAliases(@SuppressWarnings("HiddenField") String jobId, Action | |||
| final String writeAliasName = AnomalyDetectorsIndex.resultsWriteAlias(jobId); | |||
|
|
|||
| // first find the concrete indices associated with the aliases | |||
| GetAliasesRequest aliasesRequest = new GetAliasesRequest().aliases(readAliasName, writeAliasName) | |||
| .indicesOptions(IndicesOptions.lenientExpandOpenHidden()); | |||
| GetAliasesRequest aliasesRequest = new GetAliasesRequest(MasterNodeRequest.INFINITE_MASTER_NODE_TIMEOUT).aliases( | |||
There was a problem hiding this comment.
Same here regarding infinite timeout.
| @@ -694,7 +695,7 @@ public void resolveAsSeparateMappings( | |||
| } | |||
|
|
|||
| private static GetAliasesRequest createGetAliasesRequest(FieldCapabilitiesResponse response, boolean includeFrozen) { | |||
| return new GetAliasesRequest().aliases("*") | |||
| return new GetAliasesRequest(MasterNodeRequest.INFINITE_MASTER_NODE_TIMEOUT).aliases("*") | |||
There was a problem hiding this comment.
This method is only used by the sql x-pack plugin, which I interpreted as internal use as well.
💔 Backport failed
You can use sqren/backport to manually backport by running |
nielsbauman
removed
backport pending
v8.18.0
auto-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the use of the trappy default master node timeout and configures a sensible default instead.
Relates #107984