-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inference API] Fix Azure AI Studio Integration for Completions and Embeddings #119818
base: main
Are you sure you want to change the base?
Conversation
…ngs, tests are broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good stuff! 👏 Gave it a first pass and left some comments, already looking good
...xpack/inference/external/request/azureaistudio/AzureAiStudioChatCompletionRequestEntity.java
Outdated
Show resolved
Hide resolved
...rch/xpack/inference/external/request/azureaistudio/AzureAiStudioEmbeddingsRequestEntity.java
Outdated
Show resolved
Hide resolved
...a/org/elasticsearch/xpack/inference/external/request/azureaistudio/AzureAiStudioRequest.java
Show resolved
Hide resolved
...h/xpack/inference/external/response/azureaistudio/AzureAiStudioEmbeddingsResponseEntity.java
Outdated
Show resolved
Hide resolved
...elasticsearch/xpack/inference/external/request/azureaistudio/AzureAiStudioRequestFields.java
Outdated
Show resolved
Hide resolved
...a/org/elasticsearch/xpack/inference/services/azureaistudio/AzureAiStudioServiceSettings.java
Outdated
Show resolved
Hide resolved
.../inference/external/request/azureaistudio/AzureAiStudioChatCompletionRequestEntityTests.java
Outdated
Show resolved
Hide resolved
.../inference/external/request/azureaistudio/AzureAiStudioChatCompletionRequestEntityTests.java
Outdated
Show resolved
Hide resolved
...pack/inference/external/request/azureaistudio/AzureAiStudioEmbeddingsRequestEntityTests.java
Show resolved
Hide resolved
...arch/xpack/inference/external/request/azureaistudio/AzureAiStudioEmbeddingsRequestTests.java
Outdated
Show resolved
Hide resolved
Note: I'm waiting to complete the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly left comments around changes we need to address with regards to the transport level changes - we can also sync on that, it can be a bit confusing in the beginning
This draft PR fixes the Inference API integration with Azure AI Foundry (previously Azure AI Studio). The previous integration was broken for both completions and embeddings models due to API changes from Microsoft.
Core Changes:
AzureAiStudioDeploymentType
to the service settingsazure_ai_model_inference_service
orserverless_api
Once testing is complete, I will add more detailed docs describing the deployment types, their configurations, and describe how to use this integration with screenshots from the Azure console.
Local Testing:
Embeddings:
Completions:
Related Issues:
Helpful Links: