Ensure autoexpand keeps shards on remaining nodes #119829
Open
+135
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a test that ensures that during node replacement autoexpand removes a shard from node to be shutdown (and not any other node) and adds a new one to the replacement node.
idegtiarenko
added
>test
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
idegtiarenko
requested review from
DaveCTurner
and removed request for
henningandersen
idegtiarenko
changed the title
pxsalehi
reviewed
Jan 10, 2025
| @@ -405,6 +412,75 @@ private void assertThatAutoExpandReplicasDidNotContract(IndexMetadata indexMetad | |||
| ); | |||
| } | |||
|
|
|||
| public void testShouldKeepAllShardOnRemainingNodes() { | |||
| @@ -207,6 +215,51 @@ public void testAutoExpandDuringNodeReplacement() { | |||
| ); | |||
| } | |||
|
|
|||
| @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/119843") | |||
| public void testShouldKeepAllShardOnRemainingNodes() { | |||
There was a problem hiding this comment.
I find it odd to introduces a test that is muted. IMO, this belongs to a PR that also includes a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a test that ensures that during node replacement autoexpand
removes a shard from node to be shutdown (and not any other node)
and adds a new one to the replacement node.