[Entitlements] Add "always denied" network access checks #119867
Merged
+166
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
prdoyle
approved these changes
Jan 10, 2025
|
|
||
| session.getSessionContext(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
It occurs to me that if we changed CheckAction to take a version of Runnable that allows exceptions, we could remove all these re-throws.
There was a problem hiding this comment.
Ummm... good idea. I'll do that in my other open PR to avoid churn on this one.
| @SuppressWarnings("deprecation") | ||
| private static void createURLWithURLStreamHandler2() { | ||
| try { | ||
| var x = new URL(null, "spec", new URLStreamHandler() { |
There was a problem hiding this comment.
Why are we forbidding people from making URLs?
There was a problem hiding this comment.
We are forbidding only making URls with a specific, custom stream handler. This has a special permission in SM, that's why these 2 ctors arrived on our radar.
💚 Backport successful
|
ldematte
added a commit
to ldematte/elasticsearch
that referenced
this pull request
Jan 13, 2025
martijnvg
pushed a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jan 14, 2025
ldematte
added a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are always denied because a) they set global things/they can change the behaviour of how things are handled or b) were are always denied today in our SM configuration.