Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up the frozen indices deprecation to CRITICAL #119879

Conversation

PeteGillinElastic
Copy link
Member

We will be removing the ability to read frozen indices in 9.0, so we should issue a critical level deprecation issue in 8.18 and 8.19.

We will be removing the ability to read frozen indices in 9.0, so we
should issue a critical level deprecation issue in 8.18 and 8.19.
@PeteGillinElastic PeteGillinElastic force-pushed the frozen-indices-critical-deprecation branch from 35523f2 to 11c7dcc Compare January 9, 2025 17:01
@PeteGillinElastic PeteGillinElastic added :Data Management/Indices APIs APIs to create and manage indices and templates >deprecation labels Jan 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @PeteGillinElastic, I've created a changelog YAML for you. Note that since this PR is labelled >deprecation, you need to update the changelog YAML to fill out the extended information sections.

@PeteGillinElastic PeteGillinElastic marked this pull request as ready for review January 9, 2025 18:14
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 9, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a super minor nit

+ indexName
+ "] is a frozen index. The frozen indices feature is deprecated and will be removed in a future version",
DeprecationIssue.Level.CRITICAL,
"Index [" + indexName + "] is a frozen index. The frozen indices feature will be removed in version 9.0.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to remove the "is deprecated and" part of this, since it's still deprecated. We don't want to give the impression we're removing something abruptly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a 'nit' in terms of the size of the change, but that doesn't mean that it's not important! Done.

@PeteGillinElastic PeteGillinElastic enabled auto-merge (squash) January 10, 2025 10:01
@PeteGillinElastic PeteGillinElastic enabled auto-merge (squash) January 10, 2025 10:03
@PeteGillinElastic PeteGillinElastic enabled auto-merge (squash) January 10, 2025 10:04
@PeteGillinElastic PeteGillinElastic merged commit ea4879d into elastic:8.x Jan 10, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >deprecation Team:Data Management Meta label for data/management team v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants