-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Up the frozen indices deprecation to CRITICAL
#119879
Up the frozen indices deprecation to CRITICAL
#119879
Conversation
We will be removing the ability to read frozen indices in 9.0, so we should issue a critical level deprecation issue in 8.18 and 8.19.
35523f2
to
11c7dcc
Compare
Hi @PeteGillinElastic, I've created a changelog YAML for you. Note that since this PR is labelled |
Pinging @elastic/es-data-management (Team:Data Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a super minor nit
+ indexName | ||
+ "] is a frozen index. The frozen indices feature is deprecated and will be removed in a future version", | ||
DeprecationIssue.Level.CRITICAL, | ||
"Index [" + indexName + "] is a frozen index. The frozen indices feature will be removed in version 9.0.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to remove the "is deprecated and" part of this, since it's still deprecated. We don't want to give the impression we're removing something abruptly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be a 'nit' in terms of the size of the change, but that doesn't mean that it's not important! Done.
We will be removing the ability to read frozen indices in 9.0, so we should issue a critical level deprecation issue in 8.18 and 8.19.