Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes and unmutes testCancellationDuringTimeSeriesAggregation #119925

Conversation

piergm
Copy link
Member

@piergm piergm commented Jan 10, 2025

Using the same client to set error_trace and to perform the request in order to maintain threadContext.

closes: #118992

@piergm piergm added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations v9.0.0 v8.18.0 labels Jan 10, 2025
@piergm piergm self-assigned this Jan 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM man how did I miss this :D Thanks!

@piergm piergm merged commit 5f9efb5 into elastic:main Jan 10, 2025
16 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 119925

@piergm
Copy link
Member Author

piergm commented Jan 10, 2025

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

piergm added a commit to piergm/elasticsearch that referenced this pull request Jan 10, 2025
(cherry picked from commit 5f9efb5)

# Conflicts:
#	muted-tests.yml
piergm added a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] SearchCancellationIT testCancellationDuringTimeSeriesAggregation failing
3 participants