Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix knn query tests as we now do queries with k #119942

Merged

Conversation

benwtrent
Copy link
Member

Since we do the queries with k now, need to update the required feature set for the tests.

The reason for doing the queries with k is to ensure coverage since now we automatically set k to size

related: #119700

closes: #119760
closes: #119805
closes: #119804

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search v8.18.0 labels Jan 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jan 10, 2025
@benwtrent benwtrent added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 13, 2025
@elasticsearchmachine elasticsearchmachine merged commit b10643e into elastic:8.x Jan 14, 2025
15 checks passed
@benwtrent benwtrent deleted the tests/fix-knn-query-bwc-tests branch January 14, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants