Remove assumed features in server for 9.0 #119946
Draft
+90
−1,602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
commented
Jan 10, 2025
| @@ -91,6 +91,12 @@ public boolean clusterHasFeature(String featureId, boolean any) { | |||
| } | |||
|
|
|||
| if (hasFeatureMetadata()) { | |||
| if (isRestApiCompatibilityTest()) { | |||
There was a problem hiding this comment.
This is required because the compatibility tests take the test definitions from the earlier version, which contains conditions on various features. Given there's other checks that features are not removed, the only way this can happen here is if the feature has been bona-fide removed as part of moving past a compatibility barrier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove features defined in the main server jar that are marked as assumed in 8.18