Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connector API] Remove dead serialisation code for connector secrets endpoints #119949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Jan 10, 2025

Changes

Connectors APIs transport actions are always executed locally, which means that the transport requests and responses are never serialised over the wire between cluster nodes.

This PR removes the serialisation dead code for connector secrets endpoints and logic (1 out of 3 PRs to remove dead serialisation code from API implementation)

This PR follows the approach from this PR #105497 see more context in following issue: #100111

Remove all serialisation tests

Verification

  • Pipeline is green
  • Verified locally

@elasticsearchmachine elasticsearchmachine added the Team:SearchOrg Meta label for the Search Org (Enterprise Search) label Jan 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-extract-and-transform (Team:Search - Extract & Transform)

Copy link
Member

@artem-shelkovnikov artem-shelkovnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more info about serialisation? Is there any doc that can be read about it? Why was it added before?

@jedrazb
Copy link
Member Author

jedrazb commented Jan 10, 2025

Can you add more info about serialisation? Is there any doc that can be read about it? Why was it added before?

@artem-shelkovnikov this Github issue describes the situation pretty well: #100111.

Context:

  • @jimczi pointed out that Connector APIs are executed locally on the node receiving the request so there is no need for serialisation by wire

Why was serialisation by wire added?

  • Honestly I was pretty new to ES when implementing this and I just followed pattern from query rules implementation that implements this logic
  • The transport action superclass enforces the request/response action to implement Writeable interface, I was not aware that for local actions we can use TransportAction.localOnly(); as a workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :SearchOrg/Extract&Transform Label for the Search E&T team Team:Search - Extract & Transform Team:SearchOrg Meta label for the Search Org (Enterprise Search) v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants