Fix potential file leak in ES816BinaryQuantizedVectorsWriter #120014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Search Relevance/Search
iverase
changed the title
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Hi @iverase, I've created a changelog YAML for you. |
carlosdelest
approved these changes
Jan 13, 2025
benwtrent
reviewed
Jan 13, 2025
...test/java/org/elasticsearch/index/codec/vectors/es816/ES816BinaryQuantizedVectorsWriter.java
Outdated
Show resolved
Hide resolved
benwtrent
approved these changes
Jan 13, 2025
…sticsearch into BinaryQuantizedVectorsWriter
|
Ok, I rework it so we don't close twice the same file. |
iverase
added
the
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Jan 14, 2025
…lastic#120014) We are creating tmp files that might not get closed if an exception happens just after it. This commit makes sure all errors are handle properly and files are getting closed and deleted. # Conflicts: # muted-tests.yml
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Jan 14, 2025
…lastic#120014) We are creating tmp files that might not get closed if an exception happens just after it. This commit makes sure all errors are handle properly and files are getting closed and deleted. # Conflicts: # muted-tests.yml
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Jan 14, 2025
…#120014) We are creating tmp files that might not get closed if an exception happens just after it. This commit makes sure all errors are handle properly and files are getting closed and deleted. # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 14, 2025
#120091) We are creating tmp files that might not get closed if an exception happens just after it. This commit makes sure all errors are handle properly and files are getting closed and deleted. # Conflicts: # muted-tests.yml
martijnvg
pushed a commit
to martijnvg/elasticsearch
that referenced
this pull request
Jan 14, 2025
…#120014) We are creating tmp files that might not get closed if an exception happens just after it. This commit makes sure all errors are handle properly and files are getting closed and deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are creating tmp files that might not get closed if an exception happens just after it. This PR makes sure all errors are handle properly and files are getting closed and deleted.
fixes #119981