Resume Driver on cancelled or early finished #120020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
changed the title
dnhatn
force-pushed
the
driver-blocking
branch
2 times, most recently
from
857b697 to
f250e18
Compare
dnhatn
changed the title
dnhatn
force-pushed
the
driver-blocking
branch
8 times, most recently
from
c22faad to
955aa6b
Compare
|
Hi @dnhatn, I've created a changelog YAML for you. |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
dnhatn
force-pushed
the
driver-blocking
branch
from
9d435c3 to
5843e29
Compare
dnhatn
added
:Analytics/ES|QL
|
Hi @dnhatn, I've created a changelog YAML for you. |
This reverts commit 03c65d0100314855345ad16625c9ab543f74a7c2.
|
I tested this against #118122 and it seems to work fine and eliminated the need for |
smalyshev
approved these changes
Jan 14, 2025
nik9000
approved these changes
Jan 14, 2025
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/Driver.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/Driver.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/Operator.java
Outdated
Show resolved
Hide resolved
|
Thanks, Stas, for testing this patch! Thanks, Nik, for the feedback - it makes sense. I've made two changes:
|
dnhatn
added
the
auto-backport
💚 Backport successful
|
smalyshev
added a commit
to smalyshev/elasticsearch
that referenced
this pull request
Jan 15, 2025
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 15, 2025
Today, when a Driver is put to sleep or scheduled but the thread pool is busy with other tasks, canceling the Driver must wait until the Driver is awakened and scheduled for another loop, or until the thread pool completes the tasks ahead of it. A similar issue occurs with early finishes. This change enables preemptive early finishes or cancellations of the Driver without waiting for another run loop.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Resume Driver on cancelled or early finished (#120020) Today, when a Driver is put to sleep or scheduled but the thread pool is busy with other tasks, canceling the Driver must wait until the Driver is awakened and scheduled for another loop, or until the thread pool completes the tasks ahead of it. A similar issue occurs with early finishes. This change enables preemptive early finishes or cancellations of the Driver without waiting for another run loop. * compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, when a Driver is put to sleep or scheduled but the thread pool is busy with other tasks, canceling the Driver must wait until the Driver is awakened and scheduled for another loop, or until the thread pool completes the tasks ahead of it. A similar issue occurs with early finishes.
This change enables preemptive early finishes or cancellations of the Driver without waiting for another run loop.