Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow ups after Add Index Block API changes for N-2 support #120526

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Follow ups after Add Index Block API changes for N-2 support #120526

merged 5 commits into from
Jan 22, 2025

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jan 21, 2025 •
edited
Loading

This change contains follows ups now the Add Index Block API change is merged.

The index setting index.verified_read_onlycan now be PrivateIndex and not Dynamic anymore. Regular indices in version N-2 can recover if they have the index.block.read_only too. And finally, upgrade tests can use the Add Index Block API instead of manually flushing and adding blocks explicitly.

This change requires #120537 for 8.x (tests will fail until it is merged).

Relates #119743
Relates #120522

@tlrx
Use Add Index Block API in N-2 upgrade tests
4187d1c 
Now the Add Index Block API automatically synchronizes
the translog, flushes the shard and sets the verified
setting, we can use it in the N-2 upgrade tests instead
of explicit calls.

Relates elastic#119743
Relates elastic#120522
@tlrx tlrx added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v9.0.0 labels Jan 21, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Indexing Meta label for Distributed Indexing team label Jan 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

@tlrx tlrx marked this pull request as draft January 21, 2025 12:56
@tlrx tlrx changed the title Use Add Index Block API in N-2 upgrade tests Follow ups after Add Index Block API changes for N-2 support Jan 21, 2025
@tlrx tlrx mentioned this pull request Jan 21, 2025
Merged
@tlrx tlrx marked this pull request as ready for review January 22, 2025 07:47
@tlrx tlrx requested a review from henningandersen January 22, 2025 08:51
henningandersen
henningandersen approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

tlrx added a commit that referenced this pull request Jan 22, 2025
@tlrx
[8.x] Follow ups after Add Index Block API changes for N-2 support (#…
37e39f4 
…120537)

Changes in 8.x to allow regular indices in version N-2 to recover 
using the index.block.read_only too. 

Also makes the index.verified_read_only private.

Relates #120526
@tlrx tlrx added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 22, 2025
@elasticsearchmachine elasticsearchmachine merged commit 93bc758 into elastic:main Jan 22, 2025
16 checks passed
@tlrx tlrx deleted the 2025/01/21/update-tests-with-mark-as-read-only-api branch January 22, 2025 10:40
@tlrx
Copy link
Member Author

tlrx commented Jan 22, 2025

Thanks Henning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningandersen henningandersen henningandersen approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. Team:Distributed Indexing Meta label for Distributed Indexing team >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tlrx @elasticsearchmachine @henningandersen