-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source_content_type to _common.json rest spec #59840
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but one nitpick as I rather have folks using the POST variants then using _source
as a request parameter.
rest-api-spec/src/main/resources/rest-api-spec/api/_common.json
Outdated
Show resolved
Hide resolved
A couple of the checks have failed. Is there a way to re-run these? |
Pinging @elastic/clients-team (Team:Clients) |
Jenkins run elasticsearch-ci/bwc please |
Jenkins run elasticsearch-ci/default-distro please |
@russcam you might need to rebase this again to get the remaining ci jobs green |
This commit adds the source_content_type parameter to the _common.json parameters. source_content_type is required when passing a URL-encoded request definition using the source parameter.
d8b338a
to
3efcd26
Compare
Rebased against master, @Mpdreamz |
This commit adds the
source_content_type
parameter to the_common.json
parameters.source_content_type
is required when passing a URL-encoded request definition using the source parameter.