Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source_content_type to _common.json rest spec #59840

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jul 20, 2020

This commit adds the source_content_type parameter to the _common.json parameters. source_content_type is required when passing a URL-encoded request definition using the source parameter.

Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but one nitpick as I rather have folks using the POST variants then using _source as a request parameter.

@russcam
Copy link
Contributor Author

russcam commented Sep 9, 2020

A couple of the checks have failed. Is there a way to re-run these?

@andreidan andreidan added the Team:Clients Meta label for clients team label Dec 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@Mpdreamz
Copy link
Member

Jenkins run elasticsearch-ci/bwc please

@Mpdreamz
Copy link
Member

Jenkins run elasticsearch-ci/default-distro please
Jenkins run elasticsearch-ci/eql-correctness please

@Mpdreamz
Copy link
Member

@russcam you might need to rebase this again to get the remaining ci jobs green

This commit adds the source_content_type parameter
to the _common.json parameters. source_content_type
is required when passing a URL-encoded request
definition using the source parameter.
@russcam russcam force-pushed the rest-specs/source-content-type branch from d8b338a to 3efcd26 Compare February 14, 2022 12:23
@russcam
Copy link
Contributor Author

russcam commented Feb 14, 2022

Rebased against master, @Mpdreamz

@elasticsearchmachine elasticsearchmachine changed the base branch from master to main July 22, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Clients Meta label for clients team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants