Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vega] Fix highlight for HJSON #208858

Merged
merged 7 commits into from
Feb 3, 2025
Merged

[Vega] Fix highlight for HJSON #208858

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e69dad5
fix(vega): mark registerLanguages as sideEffect
markov00 Jan 29, 2025
e9f9364
Merge branch 'main' into 2025_01_29-fix_vega_highlight
markov00 Jan 31, 2025
d2350a5
add test to check the monaco registered languagess
markov00 Jan 31, 2025
2042666
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Jan 31, 2025
d03804c
fix type error
markov00 Jan 31, 2025
d493861
add back the sideEffect
markov00 Feb 3, 2025
b16159d
Merge branch 'main' into 2025_01_29-fix_vega_highlight
markov00 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add back the sideEffect
  • Loading branch information
@markov00
markov00 committed Feb 3, 2025
commit d49386192ff97e038e40e64eafeff5d4b7fb77e9
4 changes: 3 additions & 1 deletion src/platform/packages/shared/shared-ux/code_editor/impl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@
"private": true,
"version": "1.0.0",
"license": "Elastic License 2.0 OR AGPL-3.0-only OR SSPL-1.0",
"sideEffects": false
"sideEffects": [
"./register_languages.ts"
]
}