[Security Solution] Fix prebuilt rules exclusion on bulk edit #209992
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xcrzx
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
Historycc @xcrzx |
nikitaindik
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Thanks, @xcrzx!
I have tested by triggering all bulk actions available in UI in both ESS (Basic) and Serverless (Essentials). It works as expected - bulk actions that modify rule content are applied only to custom rules. Correct error code is returned. Exports also work only for custom rules. Adding actions, enabling/disabling, duplicating and deleting apply to both custom a prebuilt rules. 👍
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…c#209992) **Resolves: elastic#209888 ## Summary Resolves an issue when prebuilt rules were not excluded from bulk operations when the license tier is not sufficient to customize prebuilt rules. See the attached issue for reproduction steps. **Before** https://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3 **After** https://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21 (cherry picked from commit 376754a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…c#209992) **Resolves: elastic#209888 ## Summary Resolves an issue when prebuilt rules were not excluded from bulk operations when the license tier is not sufficient to customize prebuilt rules. See the attached issue for reproduction steps. **Before** https://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3 **After** https://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21 (cherry picked from commit 376754a)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
…c#209992) **Resolves: elastic#209888 ## Summary Resolves an issue when prebuilt rules were not excluded from bulk operations when the license tier is not sufficient to customize prebuilt rules. See the attached issue for reproduction steps. **Before** https://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3 **After** https://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21 (cherry picked from commit 376754a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…209992) (#210851) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)](#209992) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dmitrii Shevchenko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-12T15:04:13Z","message":"[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)\n\n**Resolves: https://github.com/elastic/kibana/issues/209888**\n\n## Summary\n\nResolves an issue when prebuilt rules were not excluded from bulk\noperations when the license tier is not sufficient to customize prebuilt\nrules.\n\nSee the attached issue for reproduction steps.\n\n**Before**\n\n\nhttps://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3\n\n**After**\n\n\nhttps://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21","sha":"376754afb4f1e630d26d00560fc4ae124141900f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix prebuilt rules exclusion on bulk edit","number":209992,"url":"https://github.com/elastic/kibana/pull/209992","mergeCommit":{"message":"[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)\n\n**Resolves: https://github.com/elastic/kibana/issues/209888**\n\n## Summary\n\nResolves an issue when prebuilt rules were not excluded from bulk\noperations when the license tier is not sufficient to customize prebuilt\nrules.\n\nSee the attached issue for reproduction steps.\n\n**Before**\n\n\nhttps://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3\n\n**After**\n\n\nhttps://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21","sha":"376754afb4f1e630d26d00560fc4ae124141900f"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209992","number":209992,"mergeCommit":{"message":"[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)\n\n**Resolves: https://github.com/elastic/kibana/issues/209888**\n\n## Summary\n\nResolves an issue when prebuilt rules were not excluded from bulk\noperations when the license tier is not sufficient to customize prebuilt\nrules.\n\nSee the attached issue for reproduction steps.\n\n**Before**\n\n\nhttps://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3\n\n**After**\n\n\nhttps://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21","sha":"376754afb4f1e630d26d00560fc4ae124141900f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dmitrii Shevchenko <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…209992) (#210852) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)](#209992) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dmitrii Shevchenko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-12T15:04:13Z","message":"[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)\n\n**Resolves: https://github.com/elastic/kibana/issues/209888**\n\n## Summary\n\nResolves an issue when prebuilt rules were not excluded from bulk\noperations when the license tier is not sufficient to customize prebuilt\nrules.\n\nSee the attached issue for reproduction steps.\n\n**Before**\n\n\nhttps://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3\n\n**After**\n\n\nhttps://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21","sha":"376754afb4f1e630d26d00560fc4ae124141900f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix prebuilt rules exclusion on bulk edit","number":209992,"url":"https://github.com/elastic/kibana/pull/209992","mergeCommit":{"message":"[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)\n\n**Resolves: https://github.com/elastic/kibana/issues/209888**\n\n## Summary\n\nResolves an issue when prebuilt rules were not excluded from bulk\noperations when the license tier is not sufficient to customize prebuilt\nrules.\n\nSee the attached issue for reproduction steps.\n\n**Before**\n\n\nhttps://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3\n\n**After**\n\n\nhttps://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21","sha":"376754afb4f1e630d26d00560fc4ae124141900f"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209992","number":209992,"mergeCommit":{"message":"[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)\n\n**Resolves: https://github.com/elastic/kibana/issues/209888**\n\n## Summary\n\nResolves an issue when prebuilt rules were not excluded from bulk\noperations when the license tier is not sufficient to customize prebuilt\nrules.\n\nSee the attached issue for reproduction steps.\n\n**Before**\n\n\nhttps://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3\n\n**After**\n\n\nhttps://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21","sha":"376754afb4f1e630d26d00560fc4ae124141900f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dmitrii Shevchenko <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…209992) (#210853) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)](#209992) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dmitrii Shevchenko","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-12T15:04:13Z","message":"[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)\n\n**Resolves: https://github.com/elastic/kibana/issues/209888**\n\n## Summary\n\nResolves an issue when prebuilt rules were not excluded from bulk\noperations when the license tier is not sufficient to customize prebuilt\nrules.\n\nSee the attached issue for reproduction steps.\n\n**Before**\n\n\nhttps://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3\n\n**After**\n\n\nhttps://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21","sha":"376754afb4f1e630d26d00560fc4ae124141900f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Security Solution] Fix prebuilt rules exclusion on bulk edit","number":209992,"url":"https://github.com/elastic/kibana/pull/209992","mergeCommit":{"message":"[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)\n\n**Resolves: https://github.com/elastic/kibana/issues/209888**\n\n## Summary\n\nResolves an issue when prebuilt rules were not excluded from bulk\noperations when the license tier is not sufficient to customize prebuilt\nrules.\n\nSee the attached issue for reproduction steps.\n\n**Before**\n\n\nhttps://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3\n\n**After**\n\n\nhttps://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21","sha":"376754afb4f1e630d26d00560fc4ae124141900f"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209992","number":209992,"mergeCommit":{"message":"[Security Solution] Fix prebuilt rules exclusion on bulk edit (#209992)\n\n**Resolves: https://github.com/elastic/kibana/issues/209888**\n\n## Summary\n\nResolves an issue when prebuilt rules were not excluded from bulk\noperations when the license tier is not sufficient to customize prebuilt\nrules.\n\nSee the attached issue for reproduction steps.\n\n**Before**\n\n\nhttps://github.com/user-attachments/assets/0f791c4d-f98c-4b97-867d-d8da566eb3a3\n\n**After**\n\n\nhttps://github.com/user-attachments/assets/8ed2a1e4-d298-4173-95ca-565e0c280c21","sha":"376754afb4f1e630d26d00560fc4ae124141900f"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dmitrii Shevchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #209888
Summary
Resolves an issue when prebuilt rules were not excluded from bulk operations when the license tier is not sufficient to customize prebuilt rules.
See the attached issue for reproduction steps.
Before
Screen.Recording.2025-02-05.at.11.27.53.AM.mov
After
Screen.Recording.2025-02-06.at.12.48.58.mov