[Fleet] Fix source mode synthetics when handling experimental datastream features #210195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
juliaElastic
reviewed
Feb 7, 2025
...rm/plugins/shared/fleet/server/services/package_policies/experimental_datastream_features.ts
Outdated
Show resolved
Hide resolved
…a into fix-source-mode-synthetic
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
cc @nchaulet |
|
Starting backport for target branches: 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 10, 2025
…eam features (elastic#210195) (cherry picked from commit d2070ca)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nchaulet
added
backport:version
|
Starting backport for target branches: 8.18, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 10, 2025
…eam features (elastic#210195) (cherry picked from commit d2070ca)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 10, 2025
…eam features (elastic#210195) (cherry picked from commit d2070ca)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 10, 2025
…datastream features (#210195) (#210376) # Backport This will backport the following commits from `main` to `8.18`: - [[Fleet] Fix source mode synthetics when handling experimental datastream features (#210195)](#210195) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-10T13:00:59Z","message":"[Fleet] Fix source mode synthetics when handling experimental datastream features (#210195)","sha":"d2070ca7242a832c158d9a8dd4edcc8bd806649a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Fleet] Fix source mode synthetics when handling experimental datastream features","number":210195,"url":"https://github.com/elastic/kibana/pull/210195","mergeCommit":{"message":"[Fleet] Fix source mode synthetics when handling experimental datastream features (#210195)","sha":"d2070ca7242a832c158d9a8dd4edcc8bd806649a"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.x"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210195","number":210195,"mergeCommit":{"message":"[Fleet] Fix source mode synthetics when handling experimental datastream features (#210195)","sha":"d2070ca7242a832c158d9a8dd4edcc8bd806649a"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"https://github.com/elastic/kibana/pull/210370","number":210370,"branch":"9.0","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 10, 2025
…atastream features (#210195) (#210370) # Backport This will backport the following commits from `main` to `9.0`: - [[Fleet] Fix source mode synthetics when handling experimental datastream features (#210195)](#210195) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-10T13:00:59Z","message":"[Fleet] Fix source mode synthetics when handling experimental datastream features (#210195)","sha":"d2070ca7242a832c158d9a8dd4edcc8bd806649a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v9.1.0"],"title":"[Fleet] Fix source mode synthetics when handling experimental datastream features","number":210195,"url":"https://github.com/elastic/kibana/pull/210195","mergeCommit":{"message":"[Fleet] Fix source mode synthetics when handling experimental datastream features (#210195)","sha":"d2070ca7242a832c158d9a8dd4edcc8bd806649a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210195","number":210195,"mergeCommit":{"message":"[Fleet] Fix source mode synthetics when handling experimental datastream features (#210195)","sha":"d2070ca7242a832c158d9a8dd4edcc8bd806649a"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to https://github.com/elastic/ingest-dev/issues/4863
Looks like we were still setting a deprecated _source mode synthetic when handling experiemental datastream features, that PR fix that.
I am wondering if that feature is still used? and if we should plan to clean it in a near future?