Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [streams] show inheriting streams/inherited retention when updating lifecycle (#210055) #210400

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ifecycle (elastic#210055)

When updating a wired streams lifecycle, the new configuration have side
effects that are not obvious.

This change surfaces:
- the child streams that will inherit the new configuration and thus be
updated, if any
- from which parent we inherit the new configuration when _resetting to
default_

The change also includes a refactor of the retention input validation as
a elastic#208461 follow up

-----
![Screenshot 2025-02-06 at 17 27
10](https://github.com/user-attachments/assets/378421f6-2cd5-4aea-8f4b-c53acdb794c4)

![Screenshot 2025-02-06 at 17 26
26](https://github.com/user-attachments/assets/64e5b165-92f4-484c-99bc-a1375edab771)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit f947bd3)
@kibanamachine kibanamachine merged commit def9397 into elastic:8.x Feb 10, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #1 / capacity based claiming should claim tasks until the next task will exceed capacity

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 306 308 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/streams-schema 251 257 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 300.9KB 303.9KB +3.0KB
Unknown metric groups

API count

id before after diff
@kbn/streams-schema 254 260 +6

History

cc @klacabane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants