Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] [Lens] Fix activeData in multi-layer config (#208571) #210436

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

## Summary

Fixes an issue in the lens inline editor that was assigning the first
datatable to all layers in the `activeData`.

Fixes elastic#205754

## Details

Updates the `activeData` logic in the `lens_configuration_flyout.tsx` to
match `workspace_panel.tsx`.

https://github.com/elastic/kibana/blob/82d94f17c91f8dcd93563dbbb47fba9f13c56d3a/x-pack/platform/plugins/shared/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx#L283-L295

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Release note

Fixes issue assigning color mappings when multiple layers are defined.

(cherry picked from commit dd2b833)
@nickofthyme nickofthyme changed the title [9.0] [Lens] Fix `activeData` in multi-layer config (#208571) [9.0] [Lens] Fix activeData in multi-layer config (#208571) Feb 10, 2025
@kibanamachine kibanamachine merged commit 520a007 into elastic:9.0 Feb 10, 2025
12 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #6 / incompatible_cluster_routing_allocation retries the INIT action with a descriptive message when cluster settings are incompatible

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.6MB 1.6MB +188.0B

cc @nickofthyme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants