[Solution nav] Use flyout for Stack management Security Solution #210471
+94
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 949d5d1.
tsullivan
added
v9.0.0
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
tsullivan
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
semd
reviewed
Feb 11, 2025
| { link: 'management:jobsListLink', breadcrumbStatus: 'hidden' }, | ||
| { link: 'management:pipelines', breadcrumbStatus: 'hidden' }, | ||
| { link: 'management:data_quality', breadcrumbStatus: 'hidden' }, | ||
| { link: 'management:data_usage', breadcrumbStatus: 'hidden' }, |
There was a problem hiding this comment.
This one does not exist. Should we clean it?
There was a problem hiding this comment.
Sorry about that. It was added in the original PR that this work was pulled out of: #208632. I will cherry-pick.
semd
approved these changes
Feb 11, 2025
Dosant
approved these changes
Feb 11, 2025
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
…stic#210471) This reverts commit 949d5d1 from elastic#208632 (comment). ## Summary Closes elastic#208636 Part of elastic/kibana-team#1439 </details> <details><summary>Security / Serverless (no longer in this PR)</summary>  </details> <details><summary>Security / Stateful (no longer in this PR)</summary>  </details> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] New lists of Stack Management navigation items were added for flyout menus in serverless projects using static declarations. There is a risk that these lists have missing items, which could hurt user experience by making the pages harder to navigate to. (cherry picked from commit 145d295)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
…stic#210471) This reverts commit 949d5d1 from elastic#208632 (comment). ## Summary Closes elastic#208636 Part of elastic/kibana-team#1439 </details> <details><summary>Security / Serverless (no longer in this PR)</summary>  </details> <details><summary>Security / Stateful (no longer in this PR)</summary>  </details> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] New lists of Stack Management navigation items were added for flyout menus in serverless projects using static declarations. There is a risk that these lists have missing items, which could hurt user experience by making the pages harder to navigate to. (cherry picked from commit 145d295)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
…stic#210471) This reverts commit 949d5d1 from elastic#208632 (comment). ## Summary Closes elastic#208636 Part of elastic/kibana-team#1439 </details> <details><summary>Security / Serverless (no longer in this PR)</summary>  </details> <details><summary>Security / Stateful (no longer in this PR)</summary>  </details> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] New lists of Stack Management navigation items were added for flyout menus in serverless projects using static declarations. There is a risk that these lists have missing items, which could hurt user experience by making the pages harder to navigate to. (cherry picked from commit 145d295)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
tsullivan
deleted the
solution-nav/consistent-stackmanagement-flyout-security
branch
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
#210471) (#210706) # Backport This will backport the following commits from `main` to `9.0`: - [[Solution nav] Use flyout for Stack management Security Solution (#210471)](#210471) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-11T22:04:25Z","message":"[Solution nav] Use flyout for Stack management Security Solution (#210471)\n\nThis reverts commit 949d5d1 from\r\nhttps://github.com//pull/208632#issuecomment-2644086780.\r\n\r\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/208636\r\nPart of https://github.com/elastic/kibana-team/issues/1439\r\n\r\n</details>\r\n<details><summary>Security / Serverless (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n<details><summary>Security / Stateful (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] New lists of Stack Management navigation items were added for\r\nflyout menus in serverless projects using static declarations. There is\r\na risk that these lists have missing items, which could hurt user\r\nexperience by making the pages harder to navigate to.","sha":"145d295a75e0124a8cc406a67109faef7f05413e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:SharedUX","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Solution nav] Use flyout for Stack management Security Solution","number":210471,"url":"https://github.com/elastic/kibana/pull/210471","mergeCommit":{"message":"[Solution nav] Use flyout for Stack management Security Solution (#210471)\n\nThis reverts commit 949d5d1 from\r\nhttps://github.com//pull/208632#issuecomment-2644086780.\r\n\r\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/208636\r\nPart of https://github.com/elastic/kibana-team/issues/1439\r\n\r\n</details>\r\n<details><summary>Security / Serverless (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n<details><summary>Security / Stateful (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] New lists of Stack Management navigation items were added for\r\nflyout menus in serverless projects using static declarations. There is\r\na risk that these lists have missing items, which could hurt user\r\nexperience by making the pages harder to navigate to.","sha":"145d295a75e0124a8cc406a67109faef7f05413e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210471","number":210471,"mergeCommit":{"message":"[Solution nav] Use flyout for Stack management Security Solution (#210471)\n\nThis reverts commit 949d5d1 from\r\nhttps://github.com//pull/208632#issuecomment-2644086780.\r\n\r\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/208636\r\nPart of https://github.com/elastic/kibana-team/issues/1439\r\n\r\n</details>\r\n<details><summary>Security / Serverless (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n<details><summary>Security / Stateful (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] New lists of Stack Management navigation items were added for\r\nflyout menus in serverless projects using static declarations. There is\r\na risk that these lists have missing items, which could hurt user\r\nexperience by making the pages harder to navigate to.","sha":"145d295a75e0124a8cc406a67109faef7f05413e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tim Sullivan <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
#210471) (#210705) # Backport This will backport the following commits from `main` to `8.x`: - [[Solution nav] Use flyout for Stack management Security Solution (#210471)](#210471) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-11T22:04:25Z","message":"[Solution nav] Use flyout for Stack management Security Solution (#210471)\n\nThis reverts commit 949d5d1 from\r\nhttps://github.com//pull/208632#issuecomment-2644086780.\r\n\r\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/208636\r\nPart of https://github.com/elastic/kibana-team/issues/1439\r\n\r\n</details>\r\n<details><summary>Security / Serverless (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n<details><summary>Security / Stateful (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] New lists of Stack Management navigation items were added for\r\nflyout menus in serverless projects using static declarations. There is\r\na risk that these lists have missing items, which could hurt user\r\nexperience by making the pages harder to navigate to.","sha":"145d295a75e0124a8cc406a67109faef7f05413e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:SharedUX","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Solution nav] Use flyout for Stack management Security Solution","number":210471,"url":"https://github.com/elastic/kibana/pull/210471","mergeCommit":{"message":"[Solution nav] Use flyout for Stack management Security Solution (#210471)\n\nThis reverts commit 949d5d1 from\r\nhttps://github.com//pull/208632#issuecomment-2644086780.\r\n\r\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/208636\r\nPart of https://github.com/elastic/kibana-team/issues/1439\r\n\r\n</details>\r\n<details><summary>Security / Serverless (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n<details><summary>Security / Stateful (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] New lists of Stack Management navigation items were added for\r\nflyout menus in serverless projects using static declarations. There is\r\na risk that these lists have missing items, which could hurt user\r\nexperience by making the pages harder to navigate to.","sha":"145d295a75e0124a8cc406a67109faef7f05413e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210471","number":210471,"mergeCommit":{"message":"[Solution nav] Use flyout for Stack management Security Solution (#210471)\n\nThis reverts commit 949d5d1 from\r\nhttps://github.com//pull/208632#issuecomment-2644086780.\r\n\r\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/208636\r\nPart of https://github.com/elastic/kibana-team/issues/1439\r\n\r\n</details>\r\n<details><summary>Security / Serverless (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n<details><summary>Security / Stateful (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] New lists of Stack Management navigation items were added for\r\nflyout menus in serverless projects using static declarations. There is\r\na risk that these lists have missing items, which could hurt user\r\nexperience by making the pages harder to navigate to.","sha":"145d295a75e0124a8cc406a67109faef7f05413e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tim Sullivan <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
…on (#210471) (#210704) # Backport This will backport the following commits from `main` to `8.18`: - [[Solution nav] Use flyout for Stack management Security Solution (#210471)](#210471) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-11T22:04:25Z","message":"[Solution nav] Use flyout for Stack management Security Solution (#210471)\n\nThis reverts commit 949d5d1 from\r\nhttps://github.com//pull/208632#issuecomment-2644086780.\r\n\r\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/208636\r\nPart of https://github.com/elastic/kibana-team/issues/1439\r\n\r\n</details>\r\n<details><summary>Security / Serverless (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n<details><summary>Security / Stateful (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] New lists of Stack Management navigation items were added for\r\nflyout menus in serverless projects using static declarations. There is\r\na risk that these lists have missing items, which could hurt user\r\nexperience by making the pages harder to navigate to.","sha":"145d295a75e0124a8cc406a67109faef7f05413e","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:SharedUX","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Solution nav] Use flyout for Stack management Security Solution","number":210471,"url":"https://github.com/elastic/kibana/pull/210471","mergeCommit":{"message":"[Solution nav] Use flyout for Stack management Security Solution (#210471)\n\nThis reverts commit 949d5d1 from\r\nhttps://github.com//pull/208632#issuecomment-2644086780.\r\n\r\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/208636\r\nPart of https://github.com/elastic/kibana-team/issues/1439\r\n\r\n</details>\r\n<details><summary>Security / Serverless (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n<details><summary>Security / Stateful (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] New lists of Stack Management navigation items were added for\r\nflyout menus in serverless projects using static declarations. There is\r\na risk that these lists have missing items, which could hurt user\r\nexperience by making the pages harder to navigate to.","sha":"145d295a75e0124a8cc406a67109faef7f05413e"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210471","number":210471,"mergeCommit":{"message":"[Solution nav] Use flyout for Stack management Security Solution (#210471)\n\nThis reverts commit 949d5d1 from\r\nhttps://github.com//pull/208632#issuecomment-2644086780.\r\n\r\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/208636\r\nPart of https://github.com/elastic/kibana-team/issues/1439\r\n\r\n</details>\r\n<details><summary>Security / Serverless (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n<details><summary>Security / Stateful (no longer in this PR)</summary>\r\n\r\n\r\n\r\n</details>\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n### Identify risks\r\n\r\nDoes this PR introduce any risks? For example, consider risks like hard\r\nto test bugs, performance regression, potential of data loss.\r\n\r\nDescribe the risk, its severity, and mitigation for each identified\r\nrisk. Invite stakeholders and evaluate how to proceed before merging.\r\n\r\n- [ ] New lists of Stack Management navigation items were added for\r\nflyout menus in serverless projects using static declarations. There is\r\na risk that these lists have missing items, which could hurt user\r\nexperience by making the pages harder to navigate to.","sha":"145d295a75e0124a8cc406a67109faef7f05413e"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Tim Sullivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 949d5d1 from #208632 (comment).
Summary
Closes #208636
Part of https://github.com/elastic/kibana-team/issues/1439
Security / Serverless (no longer in this PR)
Security / Stateful (no longer in this PR)
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.