[Search] Fix notebooks config path #210538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
TattdCodeMonkey
approved these changes
Feb 11, 2025
rudolf
approved these changes
Feb 11, 2025
|
Starting backport for target branches: 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 11, 2025
## Summary This updates the Search notebooks config path to fix a config conflict, now that the main search plugin owns `xpack.search`. This config should only have been used in Serverless and was never pushed to other users, but I've added a rename and deprecation warning just in case anyone used it.. (cherry picked from commit 633fad0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[Search] Fix notebooks config path (#210538)](#210538) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-11T13:14:19Z","message":"[Search] Fix notebooks config path (#210538)\n\n## Summary\r\n\r\nThis updates the Search notebooks config path to fix a config conflict,\r\nnow that the main search plugin owns `xpack.search`. This config should\r\nonly have been used in Serverless and was never pushed to other users,\r\nbut I've added a rename and deprecation warning just in case anyone used\r\nit..","sha":"633fad00f945ca8ac719b1b459b25732f04e12aa","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v9.1.0"],"title":"[Search] Fix notebooks config path","number":210538,"url":"https://github.com/elastic/kibana/pull/210538","mergeCommit":{"message":"[Search] Fix notebooks config path (#210538)\n\n## Summary\r\n\r\nThis updates the Search notebooks config path to fix a config conflict,\r\nnow that the main search plugin owns `xpack.search`. This config should\r\nonly have been used in Serverless and was never pushed to other users,\r\nbut I've added a rename and deprecation warning just in case anyone used\r\nit..","sha":"633fad00f945ca8ac719b1b459b25732f04e12aa"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210538","number":210538,"mergeCommit":{"message":"[Search] Fix notebooks config path (#210538)\n\n## Summary\r\n\r\nThis updates the Search notebooks config path to fix a config conflict,\r\nnow that the main search plugin owns `xpack.search`. This config should\r\nonly have been used in Serverless and was never pushed to other users,\r\nbut I've added a rename and deprecation warning just in case anyone used\r\nit..","sha":"633fad00f945ca8ac719b1b459b25732f04e12aa"}}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the Search notebooks config path to fix a config conflict, now that the main search plugin owns
xpack.search. This config should only have been used in Serverless and was never pushed to other users, but I've added a rename and deprecation warning just in case anyone used it..