[ObsUX][APM] Adjust timeseries charts colors #210749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiriamAparicio
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
jennypavlova
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
LGTM 🚀 The charts colors on the Overview/Transaction/Errors/Dependencies/ are different colors now and it's nice to have the red scheme for errors/failures 🙌
Q: I see the metrics colors are not changed but I guess this is not part of the scope of this PR right (they are different charts as well)?
|
Thanks for the review @jennypavlova
Those charts use Lens, Lens decided the colors there AFAIK |
💚 Build Succeeded
Metrics [docs]Async chunks
|
patpscal
approved these changes
Feb 12, 2025
|
Starting backport for target branches: 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 12, 2025
## Summary Because of the new order of colors within the list of data vis colors, we need to alternate colors when loading them in sequence in the absence of the definition of series colors overrides. This will avoid confusion between charts that are very close in color. For the same reasons, we might want to review and modify some of the values ascribed to the specific ChartType in `get_timeseries_color.ts` The bug with the charts being the same colors was introduced in this [PR](elastic#207070) BEFORE  AFTER    (cherry picked from commit d6db880)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 12, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [[ObsUX][APM] Adjust timeseries charts colors (#210749)](#210749) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Miriam","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-12T11:24:01Z","message":"[ObsUX][APM] Adjust timeseries charts colors (#210749)\n\n## Summary\r\n\r\nBecause of the new order of colors within the list of data vis colors,\r\nwe need to alternate colors when loading them in sequence in the absence\r\nof the definition of series colors overrides. This will avoid confusion\r\nbetween charts that are very close in color.\r\n\r\nFor the same reasons, we might want to review and modify some of the\r\nvalues ascribed to the specific ChartType in `get_timeseries_color.ts`\r\n\r\nThe bug with the charts being the same colors was introduced in this\r\n[PR](https://github.com/elastic/kibana/pull/207070)\r\n\r\nBEFORE\r\n\r\n\r\n\r\n\r\nAFTER\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","sha":"d6db8802da215410be9117339b1e2be07bbfb4cd","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Team:obs-ux-infra_services","v9.1.0"],"title":"[ObsUX][APM] Adjust timeseries charts colors","number":210749,"url":"https://github.com/elastic/kibana/pull/210749","mergeCommit":{"message":"[ObsUX][APM] Adjust timeseries charts colors (#210749)\n\n## Summary\r\n\r\nBecause of the new order of colors within the list of data vis colors,\r\nwe need to alternate colors when loading them in sequence in the absence\r\nof the definition of series colors overrides. This will avoid confusion\r\nbetween charts that are very close in color.\r\n\r\nFor the same reasons, we might want to review and modify some of the\r\nvalues ascribed to the specific ChartType in `get_timeseries_color.ts`\r\n\r\nThe bug with the charts being the same colors was introduced in this\r\n[PR](https://github.com/elastic/kibana/pull/207070)\r\n\r\nBEFORE\r\n\r\n\r\n\r\n\r\nAFTER\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","sha":"d6db8802da215410be9117339b1e2be07bbfb4cd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210749","number":210749,"mergeCommit":{"message":"[ObsUX][APM] Adjust timeseries charts colors (#210749)\n\n## Summary\r\n\r\nBecause of the new order of colors within the list of data vis colors,\r\nwe need to alternate colors when loading them in sequence in the absence\r\nof the definition of series colors overrides. This will avoid confusion\r\nbetween charts that are very close in color.\r\n\r\nFor the same reasons, we might want to review and modify some of the\r\nvalues ascribed to the specific ChartType in `get_timeseries_color.ts`\r\n\r\nThe bug with the charts being the same colors was introduced in this\r\n[PR](https://github.com/elastic/kibana/pull/207070)\r\n\r\nBEFORE\r\n\r\n\r\n\r\n\r\nAFTER\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","sha":"d6db8802da215410be9117339b1e2be07bbfb4cd"}}]}] BACKPORT--> Co-authored-by: Miriam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Because of the new order of colors within the list of data vis colors, we need to alternate colors when loading them in sequence in the absence of the definition of series colors overrides. This will avoid confusion between charts that are very close in color.
For the same reasons, we might want to review and modify some of the values ascribed to the specific ChartType in
get_timeseries_color.tsThe bug with the charts being the same colors was introduced in this PR
BEFORE
AFTER