[Rules migration][Integration test] Get migration rules API (#11232) #210867
+749
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e40pud
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💚 Build Succeeded
Metrics [docs]
cc @e40pud |
semd
reviewed
Feb 13, 2025
Comment on lines
+159
to
+183
| get: async ({ | ||
| migrationId, | ||
| page, | ||
| perPage, | ||
| sortField, | ||
| sortDirection, | ||
| filters, | ||
| expectStatusCode = 200, | ||
| }: GetRuleMigrationParams): Promise<{ body: GetRuleMigrationResponse }> => { | ||
| const response = await supertest | ||
| .get(replaceParams(SIEM_RULE_MIGRATION_PATH, { migration_id: migrationId })) | ||
| .query({ | ||
| page, | ||
| per_page: perPage, | ||
| sort_field: sortField, | ||
| sort_direction: sortDirection, | ||
| search_term: filters?.searchTerm, | ||
| ids: filters?.ids, | ||
| is_prebuilt: filters?.prebuilt, | ||
| is_installed: filters?.installed, | ||
| is_fully_translated: filters?.fullyTranslated, | ||
| is_partially_translated: filters?.partiallyTranslated, | ||
| is_untranslatable: filters?.untranslatable, | ||
| is_failed: filters?.failed, | ||
| }) |
There was a problem hiding this comment.
NIT: Consider using the real parameter format from the GetRuleMigrationRequestQuery type instead of doing this conversion.
There was a problem hiding this comment.
Sounds great! I will update it in my next PR.
There was a problem hiding this comment.
addressed in #210999
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 13, 2025
…11232) (elastic#210867) ## Summary [Internal link](elastic/security-team#10820) to the feature details Part of elastic/security-team#11232 This PR covers SIEM Migrations GET API (route: `/internal/siem_migrations/rules/{migration_id}`) integration test: * Basic calls * Filtering * Sorting * Pagination (cherry picked from commit 526ff05)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 13, 2025
…11232) (elastic#210867) ## Summary [Internal link](elastic/security-team#10820) to the feature details Part of elastic/security-team#11232 This PR covers SIEM Migrations GET API (route: `/internal/siem_migrations/rules/{migration_id}`) integration test: * Basic calls * Filtering * Sorting * Pagination (cherry picked from commit 526ff05)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 13, 2025
…11232) (elastic#210867) ## Summary [Internal link](elastic/security-team#10820) to the feature details Part of elastic/security-team#11232 This PR covers SIEM Migrations GET API (route: `/internal/siem_migrations/rules/{migration_id}`) integration test: * Basic calls * Filtering * Sorting * Pagination (cherry picked from commit 526ff05)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 13, 2025
…1232) (#210867) (#210998) # Backport This will backport the following commits from `main` to `9.0`: - [[Rules migration][Integration test] Get migration rules API (#11232) (#210867)](#210867) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-13T12:44:08Z","message":"[Rules migration][Integration test] Get migration rules API (#11232) (#210867)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations GET API (route:\r\n`/internal/siem_migrations/rules/{migration_id}`) integration test:\r\n* Basic calls\r\n* Filtering\r\n* Sorting\r\n* Pagination","sha":"526ff0516e701ee1e1db8a248fe8f7c86587d257","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Rules migration][Integration test] Get migration rules API (#11232)","number":210867,"url":"https://github.com/elastic/kibana/pull/210867","mergeCommit":{"message":"[Rules migration][Integration test] Get migration rules API (#11232) (#210867)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations GET API (route:\r\n`/internal/siem_migrations/rules/{migration_id}`) integration test:\r\n* Basic calls\r\n* Filtering\r\n* Sorting\r\n* Pagination","sha":"526ff0516e701ee1e1db8a248fe8f7c86587d257"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210867","number":210867,"mergeCommit":{"message":"[Rules migration][Integration test] Get migration rules API (#11232) (#210867)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations GET API (route:\r\n`/internal/siem_migrations/rules/{migration_id}`) integration test:\r\n* Basic calls\r\n* Filtering\r\n* Sorting\r\n* Pagination","sha":"526ff0516e701ee1e1db8a248fe8f7c86587d257"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 13, 2025
…11232) (#210867) (#210996) # Backport This will backport the following commits from `main` to `8.18`: - [[Rules migration][Integration test] Get migration rules API (#11232) (#210867)](#210867) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-13T12:44:08Z","message":"[Rules migration][Integration test] Get migration rules API (#11232) (#210867)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations GET API (route:\r\n`/internal/siem_migrations/rules/{migration_id}`) integration test:\r\n* Basic calls\r\n* Filtering\r\n* Sorting\r\n* Pagination","sha":"526ff0516e701ee1e1db8a248fe8f7c86587d257","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Rules migration][Integration test] Get migration rules API (#11232)","number":210867,"url":"https://github.com/elastic/kibana/pull/210867","mergeCommit":{"message":"[Rules migration][Integration test] Get migration rules API (#11232) (#210867)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations GET API (route:\r\n`/internal/siem_migrations/rules/{migration_id}`) integration test:\r\n* Basic calls\r\n* Filtering\r\n* Sorting\r\n* Pagination","sha":"526ff0516e701ee1e1db8a248fe8f7c86587d257"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210867","number":210867,"mergeCommit":{"message":"[Rules migration][Integration test] Get migration rules API (#11232) (#210867)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations GET API (route:\r\n`/internal/siem_migrations/rules/{migration_id}`) integration test:\r\n* Basic calls\r\n* Filtering\r\n* Sorting\r\n* Pagination","sha":"526ff0516e701ee1e1db8a248fe8f7c86587d257"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 13, 2025
…1232) (#210867) (#210997) # Backport This will backport the following commits from `main` to `8.x`: - [[Rules migration][Integration test] Get migration rules API (#11232) (#210867)](#210867) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-13T12:44:08Z","message":"[Rules migration][Integration test] Get migration rules API (#11232) (#210867)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations GET API (route:\r\n`/internal/siem_migrations/rules/{migration_id}`) integration test:\r\n* Basic calls\r\n* Filtering\r\n* Sorting\r\n* Pagination","sha":"526ff0516e701ee1e1db8a248fe8f7c86587d257","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Rules migration][Integration test] Get migration rules API (#11232)","number":210867,"url":"https://github.com/elastic/kibana/pull/210867","mergeCommit":{"message":"[Rules migration][Integration test] Get migration rules API (#11232) (#210867)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations GET API (route:\r\n`/internal/siem_migrations/rules/{migration_id}`) integration test:\r\n* Basic calls\r\n* Filtering\r\n* Sorting\r\n* Pagination","sha":"526ff0516e701ee1e1db8a248fe8f7c86587d257"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210867","number":210867,"mergeCommit":{"message":"[Rules migration][Integration test] Get migration rules API (#11232) (#210867)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations GET API (route:\r\n`/internal/siem_migrations/rules/{migration_id}`) integration test:\r\n* Basic calls\r\n* Filtering\r\n* Sorting\r\n* Pagination","sha":"526ff0516e701ee1e1db8a248fe8f7c86587d257"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
e40pud
added a commit
that referenced
this pull request
Feb 13, 2025
…10999) ## Summary [Internal link](elastic/security-team#10820) to the feature details Part of elastic/security-team#11232 This PR covers SIEM Migrations CREATE API (route: `/internal/siem_migrations/rules/{migration_id?}`) integration test: * Create migration with provided ID * Create migration without provided ID * Create migration with rules that have resources * Error handling ("no content") when no rules provided Also, as part of this PR, I addressed this comment to my previous changes #210867 (comment)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 13, 2025
…) (elastic#210999) ## Summary [Internal link](elastic/security-team#10820) to the feature details Part of elastic/security-team#11232 This PR covers SIEM Migrations CREATE API (route: `/internal/siem_migrations/rules/{migration_id?}`) integration test: * Create migration with provided ID * Create migration without provided ID * Create migration with rules that have resources * Error handling ("no content") when no rules provided Also, as part of this PR, I addressed this comment to my previous changes elastic#210867 (comment) (cherry picked from commit 44fdf81)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 13, 2025
…) (elastic#210999) ## Summary [Internal link](elastic/security-team#10820) to the feature details Part of elastic/security-team#11232 This PR covers SIEM Migrations CREATE API (route: `/internal/siem_migrations/rules/{migration_id?}`) integration test: * Create migration with provided ID * Create migration without provided ID * Create migration with rules that have resources * Error handling ("no content") when no rules provided Also, as part of this PR, I addressed this comment to my previous changes elastic#210867 (comment) (cherry picked from commit 44fdf81)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 13, 2025
…) (elastic#210999) ## Summary [Internal link](elastic/security-team#10820) to the feature details Part of elastic/security-team#11232 This PR covers SIEM Migrations CREATE API (route: `/internal/siem_migrations/rules/{migration_id?}`) integration test: * Create migration with provided ID * Create migration without provided ID * Create migration with rules that have resources * Error handling ("no content") when no rules provided Also, as part of this PR, I addressed this comment to my previous changes elastic#210867 (comment) (cherry picked from commit 44fdf81)
kibanamachine
added a commit
that referenced
this pull request
Feb 13, 2025
…) (#210999) (#211083) # Backport This will backport the following commits from `main` to `8.18`: - [[Rules migration][Integration test] Create migration API (#11232) (#210999)](#210999) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-13T19:20:06Z","message":"[Rules migration][Integration test] Create migration API (#11232) (#210999)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations CREATE API (route:\r\n`/internal/siem_migrations/rules/{migration_id?}`) integration test:\r\n* Create migration with provided ID\r\n* Create migration without provided ID\r\n* Create migration with rules that have resources\r\n* Error handling (\"no content\") when no rules provided\r\n\r\nAlso, as part of this PR, I addressed this comment to my previous\r\nchanges\r\nhttps://github.com//pull/210867#discussion_r1954344990","sha":"44fdf81bbec5c053ebccfbdbb062d39de0d7358c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Rules migration][Integration test] Create migration API (#11232)","number":210999,"url":"https://github.com/elastic/kibana/pull/210999","mergeCommit":{"message":"[Rules migration][Integration test] Create migration API (#11232) (#210999)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations CREATE API (route:\r\n`/internal/siem_migrations/rules/{migration_id?}`) integration test:\r\n* Create migration with provided ID\r\n* Create migration without provided ID\r\n* Create migration with rules that have resources\r\n* Error handling (\"no content\") when no rules provided\r\n\r\nAlso, as part of this PR, I addressed this comment to my previous\r\nchanges\r\nhttps://github.com//pull/210867#discussion_r1954344990","sha":"44fdf81bbec5c053ebccfbdbb062d39de0d7358c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210999","number":210999,"mergeCommit":{"message":"[Rules migration][Integration test] Create migration API (#11232) (#210999)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations CREATE API (route:\r\n`/internal/siem_migrations/rules/{migration_id?}`) integration test:\r\n* Create migration with provided ID\r\n* Create migration without provided ID\r\n* Create migration with rules that have resources\r\n* Error handling (\"no content\") when no rules provided\r\n\r\nAlso, as part of this PR, I addressed this comment to my previous\r\nchanges\r\nhttps://github.com//pull/210867#discussion_r1954344990","sha":"44fdf81bbec5c053ebccfbdbb062d39de0d7358c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 13, 2025
… (#210999) (#211085) # Backport This will backport the following commits from `main` to `9.0`: - [[Rules migration][Integration test] Create migration API (#11232) (#210999)](#210999) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-13T19:20:06Z","message":"[Rules migration][Integration test] Create migration API (#11232) (#210999)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations CREATE API (route:\r\n`/internal/siem_migrations/rules/{migration_id?}`) integration test:\r\n* Create migration with provided ID\r\n* Create migration without provided ID\r\n* Create migration with rules that have resources\r\n* Error handling (\"no content\") when no rules provided\r\n\r\nAlso, as part of this PR, I addressed this comment to my previous\r\nchanges\r\nhttps://github.com//pull/210867#discussion_r1954344990","sha":"44fdf81bbec5c053ebccfbdbb062d39de0d7358c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Rules migration][Integration test] Create migration API (#11232)","number":210999,"url":"https://github.com/elastic/kibana/pull/210999","mergeCommit":{"message":"[Rules migration][Integration test] Create migration API (#11232) (#210999)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations CREATE API (route:\r\n`/internal/siem_migrations/rules/{migration_id?}`) integration test:\r\n* Create migration with provided ID\r\n* Create migration without provided ID\r\n* Create migration with rules that have resources\r\n* Error handling (\"no content\") when no rules provided\r\n\r\nAlso, as part of this PR, I addressed this comment to my previous\r\nchanges\r\nhttps://github.com//pull/210867#discussion_r1954344990","sha":"44fdf81bbec5c053ebccfbdbb062d39de0d7358c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210999","number":210999,"mergeCommit":{"message":"[Rules migration][Integration test] Create migration API (#11232) (#210999)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations CREATE API (route:\r\n`/internal/siem_migrations/rules/{migration_id?}`) integration test:\r\n* Create migration with provided ID\r\n* Create migration without provided ID\r\n* Create migration with rules that have resources\r\n* Error handling (\"no content\") when no rules provided\r\n\r\nAlso, as part of this PR, I addressed this comment to my previous\r\nchanges\r\nhttps://github.com//pull/210867#discussion_r1954344990","sha":"44fdf81bbec5c053ebccfbdbb062d39de0d7358c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Feb 13, 2025
… (#210999) (#211084) # Backport This will backport the following commits from `main` to `8.x`: - [[Rules migration][Integration test] Create migration API (#11232) (#210999)](#210999) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-13T19:20:06Z","message":"[Rules migration][Integration test] Create migration API (#11232) (#210999)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations CREATE API (route:\r\n`/internal/siem_migrations/rules/{migration_id?}`) integration test:\r\n* Create migration with provided ID\r\n* Create migration without provided ID\r\n* Create migration with rules that have resources\r\n* Error handling (\"no content\") when no rules provided\r\n\r\nAlso, as part of this PR, I addressed this comment to my previous\r\nchanges\r\nhttps://github.com//pull/210867#discussion_r1954344990","sha":"44fdf81bbec5c053ebccfbdbb062d39de0d7358c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[Rules migration][Integration test] Create migration API (#11232)","number":210999,"url":"https://github.com/elastic/kibana/pull/210999","mergeCommit":{"message":"[Rules migration][Integration test] Create migration API (#11232) (#210999)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations CREATE API (route:\r\n`/internal/siem_migrations/rules/{migration_id?}`) integration test:\r\n* Create migration with provided ID\r\n* Create migration without provided ID\r\n* Create migration with rules that have resources\r\n* Error handling (\"no content\") when no rules provided\r\n\r\nAlso, as part of this PR, I addressed this comment to my previous\r\nchanges\r\nhttps://github.com//pull/210867#discussion_r1954344990","sha":"44fdf81bbec5c053ebccfbdbb062d39de0d7358c"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210999","number":210999,"mergeCommit":{"message":"[Rules migration][Integration test] Create migration API (#11232) (#210999)\n\n## Summary\r\n\r\n[Internal link](https://github.com/elastic/security-team/issues/10820)\r\nto the feature details\r\n\r\nPart of https://github.com/elastic/security-team/issues/11232\r\n\r\nThis PR covers SIEM Migrations CREATE API (route:\r\n`/internal/siem_migrations/rules/{migration_id?}`) integration test:\r\n* Create migration with provided ID\r\n* Create migration without provided ID\r\n* Create migration with rules that have resources\r\n* Error handling (\"no content\") when no rules provided\r\n\r\nAlso, as part of this PR, I addressed this comment to my previous\r\nchanges\r\nhttps://github.com//pull/210867#discussion_r1954344990","sha":"44fdf81bbec5c053ebccfbdbb062d39de0d7358c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Internal link to the feature details
Part of https://github.com/elastic/security-team/issues/11232
This PR covers SIEM Migrations GET API (route:
/internal/siem_migrations/rules/{migration_id}) integration test: