Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ML] Trained models: Replace download button by extending deploy action (#205699) #211029

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Feb 13, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…on (elastic#205699)

## Summary

* Removes the download model button by extending the deploy action.
* The model download begins automatically after clicking Start
Deployment.
* It is possible to queue one deployment while the model is still
downloading.
* Navigating away from the Trained Models page will not interrupt the
downloading or deployment process.
* `State` column renamed to `Model State`
* Responsiveness fix: icons overlap

https://github.com/user-attachments/assets/045d6f1f-5c2b-4cb5-ad34-ff779add80e3

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit f9c4f59)

# Conflicts:
#	x-pack/platform/plugins/shared/ml/tsconfig.json
@rbrtj rbrtj merged commit fdb5dd0 into elastic:8.x Feb 13, 2025
8 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 2419 2425 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +49.0B
indexLifecycleManagement 160.6KB 160.6KB +49.0B
indexManagement 752.5KB 752.6KB +49.0B
ingestPipelines 409.1KB 409.1KB +49.0B
ml 5.5MB 5.5MB -340.0B
spaces 256.9KB 256.9KB +49.0B
streamsApp 303.9KB 304.0KB +49.0B
total -46.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
ml 105 104 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 79.9KB 80.0KB +54.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
ml 557 560 +3

Total ESLint disabled count

id before after diff
ml 560 563 +3

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants