-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[streams] fork classic stream template #211368
Open
klacabane
wants to merge
14
commits into
elastic:main
Choose a base branch
from
klacabane:87-classic-streams-template-fork
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[streams] fork classic stream template #211368
klacabane
wants to merge
14
commits into
elastic:main
from
klacabane:87-classic-streams-template-fork
+231
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klacabane
commented
Feb 19, 2025
@@ -196,16 +197,15 @@ async function ensureStreamManagedPipelineReference( | |||
}, | |||
}, | |||
}; | |||
executionPlan.push({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced the executionPlan logic with elasticsearch calls since it does not seem to do much for now. Happy to revert if there are plans to add more to that construct
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
Feature:Streams
This is the label for the Streams Project
release_note:skip
Skip the PR/issue when compiling release notes
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying mappings or lifecycle changes to an unwired stream we don't want to update the current unmanaged index template for several reasons.
Our solution is to fork the effective template and tweak it slightly to make the streams' layer applicable in a controlled way
This change does:
@stream.layer
component template similar to the wired streams. this layer will hold the streams' specific mappings and lifecycle@base
component template so stream's layer can override themThis change does not:
these will be implemented separately
Testing
TODO