[9.0] [Obs Ai Assistant] Add system message (#209773) #211397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: System Message Missing in Inference Plugin Closes elastic#209548 ## Summary A regression was introduced in 8.18 ([elastic#199286](elastic#199286)), where the system message is no longer passed to the inference plugin and, consequently, the LLM. Currently, only user messages are being sent, which impacts conversation guidance and guardrails. The system message is crucial for steering responses and maintaining contextual integrity. The filtering of the system message happens here: https://github.com/elastic/kibana/blob/771a080ffa99e501e72c9cb98c833795769483ae/x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts#L510-L512 Fix Approach - Ensure the `system` message is included as a parameter in `inferenceClient.chatComplete.` ```typescript const options = { connectorId, system, messages: convertMessagesForInference(messages), toolChoice, tools, functionCalling: (simulateFunctionCalling ? 'simulated' : 'native') as FunctionCallingMode, }; if (stream) { return defer(() => this.dependencies.inferenceClient.chatComplete({ ...options, stream: true, }) ).pipe( convertInferenceEventsToStreamingEvents(), instrumentAndCountTokens(name), failOnNonExistingFunctionCall({ functions }), tap((event) => { if ( event.type === StreamingChatResponseEventType.ChatCompletionChunk && this.dependencies.logger.isLevelEnabled('trace') ) { this.dependencies.logger.trace(`Received chunk: ${JSON.stringify(event.message)}`); } }), shareReplay() ) as TStream extends true ? Observable<ChatCompletionChunkEvent | TokenCountEvent | ChatCompletionMessageEvent> : never; } else { return this.dependencies.inferenceClient.chatComplete({ ...options, stream: false, }) as TStream extends true ? never : Promise<ChatCompleteResponse>; } } ``` - Add an API test to verify that the system message is correctly passed to the LLM. (cherry picked from commit 0ae28aa)
9 tasks
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.0:Questions ?
Please refer to the Backport tool documentation