[UA] ML anomaly job indices special handling #211407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
rudolf
approved these changes
Feb 17, 2025
...nents/es_deprecations/deprecation_types/indices/flyout/steps/details/ml_anomaly_guidance.tsx
Outdated
Show resolved
Hide resolved
…hich only applies to non readonly indices
jloleysens
commented
Feb 18, 2025
Comment on lines
+82
to
+95
| let showEsTransformsGuidance = false; | ||
| let showMlAnomalyReindexingGuidance = false; | ||
| let showReadOnlyGuidance = false; | ||
| let showDefaultGuidance = false; | ||
|
|
||
| if (isESTransformTarget) { | ||
| showEsTransformsGuidance = true; | ||
| } else if (meta.isReadonly) { | ||
| showReadOnlyGuidance = true; | ||
| } else if (isMLAnomalyIndex) { | ||
| showMlAnomalyReindexingGuidance = true; | ||
| } else { | ||
| showDefaultGuidance = true; | ||
| } |
There was a problem hiding this comment.
Attempted to clarify this logic... We should only be showing one of these instances of guidance at a time.
rudolf
approved these changes
Feb 18, 2025
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 19, 2025
Close elastic/kibana-team#1501 <img width="535" alt="Screenshot 2025-02-17 at 11 43 19" src="https://github.com/user-attachments/assets/648cc007-aef8-4959-add8-6aec943e9e41" /> (cherry picked from commit 5d3fb74)
jloleysens
added a commit
that referenced
this pull request
Feb 19, 2025
# Backport This will backport the following commits from `8.x` to `8.18`: - [[UA] ML anomaly job indices special handling (#211407)](#211407) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Jean-Louis Leysens","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-18T11:40:27Z","message":"[UA] ML anomaly job indices special handling (#211407)\n\nClose https://github.com/elastic/kibana-team/issues/1501\r\n\r\n\r\n<img width=\"535\" alt=\"Screenshot 2025-02-17 at 11 43 19\"\r\nsrc=\"https://github.com/user-attachments/assets/648cc007-aef8-4959-add8-6aec943e9e41\"\r\n/>","sha":"5d3fb74647d24decd1adca486004244809b79957","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","Feature:Upgrade Assistant","backport:version","v8.18.0","v8.19.0"],"title":"[UA] ML anomaly job indices special handling","number":211407,"url":"https://github.com/elastic/kibana/pull/211407","mergeCommit":{"message":"[UA] ML anomaly job indices special handling (#211407)\n\nClose https://github.com/elastic/kibana-team/issues/1501\r\n\r\n\r\n<img width=\"535\" alt=\"Screenshot 2025-02-17 at 11 43 19\"\r\nsrc=\"https://github.com/user-attachments/assets/648cc007-aef8-4959-add8-6aec943e9e41\"\r\n/>","sha":"5d3fb74647d24decd1adca486004244809b79957"}},"sourceBranch":"8.x","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close https://github.com/elastic/kibana-team/issues/1501
When read only