Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs] using All logs dataview in LOGS_LOCATOR #211549

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Logs] using All logs dataview in LOGS_LOCATOR #211549

wants to merge 6 commits into from
+10 −17

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Feb 18, 2025 •
edited
Loading

Closes #209122.

🎥 Demo

Screen.Recording.2025-02-18.at.12.38.34.mov

How to test?

  1. Ingest some data using logs_and_metrics synthtrace scenario
  2. Go to /app/observability/overview or app/metrics/hosts
  3. Click logs link
  4. You should be redirected to discover and All logs should be set by default

@yngrdyn yngrdyn requested review from a team as code owners February 18, 2025 11:37
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 18, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@yngrdyn yngrdyn added the Team:obs-ux-logs Observability Logs User Experience Team label Feb 18, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@yngrdyn yngrdyn added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels v8.18.0 v8.19.0 v9.0.0 v9.1.0 and removed Team:Fleet Team label for Observability Data Collection Fleet team backport:version Backport to applied version labels labels Feb 18, 2025
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Feb 18, 2025
@gbamparop gbamparop requested a review from a team February 18, 2025 13:18
@nchaulet nchaulet self-requested a review February 18, 2025 14:02
nchaulet
nchaulet approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet I tested locally the change and it worked as expected LGTM 🚀

@yngrdyn yngrdyn requested a review from gbamparop February 19, 2025 08:56
kibanamachine and others added 3 commits February 19, 2025 09:03
@yngrdyn yngrdyn requested a review from a team as a code owner February 19, 2025 09:27
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group4 adhoc data views search results should be different after data view update
  • [job] [logs] Fleet Cypress Tests #1 / View agents list Agent status filter should filter on healthy (18 results)
  • [job] [logs] Fleet Cypress Tests #1 / View agents list Agent status filter should filter on healthy and unhealthy
  • [job] [logs] Fleet Cypress Tests #1 / View agents list Bulk actions should allow to bulk upgrade agents and cancel that upgrade

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +24.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
logsShared 130.8KB 130.7KB -81.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

@gbamparop gbamparop Awaiting requested review from gbamparop

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:obs-ux-logs Observability Logs User Experience Team v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[OneDiscover] Update links to logs with new All Logs data view
5 participants
@yngrdyn @elasticmachine @nchaulet @gbamparop @kibanamachine